Skip to contentSkip to conversation

patch: loop-5

DISCUSSION Adam Schrotenboer 2 participants 2 messages Feb 21, 2001

lore
Share & tools
lore
#0 lore raw

Jens,

Please excuse this possibly stupid q. I don't know as much about kernel hacking as I would like to.

I noticed that you are rewriting the loop block device to be a block remapper (yes, I had noticed this before, the q just never occurred to me before); does this imply that the native block size of the loop file fs must be the same size as the underlying fs? exemplia gratia, ext2 fs w/ block size 1024, iso image block size 2048; or ext2 block size 1024, reiserfs image block size 512 (I'm assuming this is possible, but don't know for sure. of course on reiserfs the likely best size is 4096 to match page size, since tails are packed anyway); or perhaps a more useful/common example than the previous: iso block size 2048, ext2 block size 1024 (most common block size, right??).

I admit that I gave one, maybe two more examples than necessary. the idea of the first two was to cover both possibilities, i.e. loop larger than base, and loop smaller than base. The third was merely to ward off the possiblity that the 3rd was and impossible configuration, and to reduce flames from various people who consider something this "elementary" to be "obvious", either in utility or specification.

#1 lore raw
Quoted 5 lines · Adam Schrotenboer

Jens,

Please excuse this possibly stupid q. I don't know as much about kernel hacking as I would like to.

Quoted 10 lines

I noticed that you are rewriting the loop block device to be a block remapper (yes, I had noticed this before, the q just never occurred to me before); does this imply that the native block size of the loop file fs must be the same size as the underlying fs? exemplia gratia, ext2 fs w/ block size 1024, iso image block size 2048; or ext2 block size 1024, reiserfs image block size 512 (I'm assuming this is possible, but don't know for sure. of course on reiserfs the likely best size is 4096 to match page size, since tails are packed anyway); or perhaps a more useful/common example than the previous: iso block size 2048, ext2 block size 1024 (most common block size, right??).

A remapper was the original idea, and the loop-remap-XX patches did that. But it gave me so many head aches exactly due to for example block size differences, and also the stacking then becomes even more problematic.

So no, the current loop patches do not use simple buffer_head remapping.

Signature · 1 line
Jens Axboe