Skip to contentSkip to conversation

Trivial bug/fix for shm.c

PATCH Eric Weigle 1 participant 1 message Feb 22, 2001

lore
Share & tools
lore
#0 lore raw

I couldn't find the maintainer for this, so I'm sending it to the list.

Problem: ipc/shm.c currently assumes proc filesystem exists, so if CONFIG_PROC_FS is not defined, it will not compile. The function shm_init calls create_proc_read_entry without checking if CONFIG_PROC_FS defined; if it isn't defined that functionality should not be referenced.

Solution: add appropriate #ifdef around that line:

--------------------------------------------------------------------------------

ipc/shm.c Thu Feb 22 13:13:57 2001 renamed from ipc/shm.c.orig Thu Feb 22 13:13:47 2001 +2 -0
@@ -71,7 +71,9 @@
 void __init shm_init (void)
 {
    ipc_init_ids(&shm_ids, 1);
+#ifdef CONFIG_PROC_FS
    create_proc_read_entry("sysvipc/shm", 0, 0, sysvipc_shm_read_proc, NULL);
+#endif
 }
 
 static inline int shm_checkid(struct shmid_kernel *s, int id)

--------------------------------------------------------------------------------

I encountered this bug while creating a vastly hacked-down special purpose kernel without /proc support.

Thanks,
-Eric Weigle

--------------------------------------------

 Eric H. Weigle   CCS-1, RADIANT team
 [email protected]     Los Alamos National Lab
 (505) 665-4937   http://home.lanl.gov/ehw/

--------------------------------------------