Skip to contentSkip to conversation

flush_page_to_ram() question in kernel/ptrace.c

DISCUSSION Manfred Spraul 2 participants 2 messages Mar 8, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 14 lines

From linux/kernel/ptrace.c, access_one_page():

       flush_cache_page(vma, addr);

        if (write) {
                maddr = kmap(page);
                memcpy(maddr + (addr & ~PAGE_MASK), buf, len);
                flush_page_to_ram(page);
                flush_icache_page(vma, page);
                kunmap(page);
        } else {
                maddr = kmap(page);
                memcpy(buf, maddr + (addr & ~PAGE_MASK), len);
                flush_page_to_ram(page);
                  ^^^^^^^^^^^^^^^^^^^^^^
Quoted 2 lines
                kunmap(page);
        }

Is this flush required?

The memcpy read from the mapping, it didn't write.

--
Manfred

#1 lore raw
Quoted 6 lines · Manfred Spraul
Quoted 2 lines
                memcpy(buf, maddr + (addr & ~PAGE_MASK), len);
                flush_page_to_ram(page);
                  ^^^^^^^^^^^^^^^^^^^^^^

Is this flush required?

The memcpy read from the mapping, it didn't write.

You have to kick it out of the cache so that future reads on the kernel side don't get stale data with caching setups that allow illegal aliases to form.

Later,
David S. Miller
[email protected]