Skip to contentSkip to conversation

appling preasure to icache and dcache

RFC PATCH Benjamin Redelings I 2 participants 2 messages Apr 3, 2001 Memory management

lore
Share & tools
lore
#0 lore raw

Hi, I'm glad somebody is working on this! VM-time seems like a pretty useful concept.

I think you have a bug in your patch here:

+ if (base > pages) /* If the cache shrunk reset base, The
cache
+ base = pages; * growing applies preasure as does
expanding
+ if (free > old) * free space - even if later shrinks */
+ base -= (base>free-old) ? free-old : base;

It looks like you unintentionally commented out two lines of code?

I have been successfully running your patch. But I think it needs
benchmarks. At the very least, compile the kernel twice w/o and twice w/ your patch and see how it changes the times. I do not think I will have time to do it myself anytime soon unfortunately.
I have a 64Mb RAM machine, and the patch makes the system feel a little
bit slower when hitting the disk. BUt that is subjective...

-BenRI

Signature · 8 lines
"...assisted of course by pride, for we teach them to describe the
 Creeping Death, as Good Sense, or Maturity, or Experience." 
- "The Screwtape Letters"
Benjamin Redelings I      <><     http://www.bol.ucla.edu/~bredelin/
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
#1 lore raw
Quoted 14 lines · Benjamin Redelings I

Hi, I'm glad somebody is working on this! VM-time seems like a pretty useful concept.

I think you have a bug in your patch here:

+ if (base > pages) /* If the cache shrunk reset base, The
cache
+ base = pages; * growing applies preasure as does
expanding

(quoted diff) +2 -0
+       if (free > old)          * free space - even if later shrinks */
+               base -= (base>free-old) ? free-old : base;

It looks like you unintentionally commented out two lines of code?

Quoted 8 lines

I have been successfully running your patch. But I think it needs
benchmarks. At the very least, compile the kernel twice w/o and twice w/ your patch and see how it changes the times. I do not think I will have time to do it myself anytime soon unfortunately.
I have a 64Mb RAM machine, and the patch makes the system feel a little
bit slower when hitting the disk. BUt that is subjective...

-BenRI

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/