Skip to contentSkip to conversation

PATCH: 2.4.3 tinny module interface cleanum

PATCH Martin Dalecki 3 participants 4 messages Apr 26, 2001 VFS

lore
Share & tools
lore

Martin Dalecki

author
#0 lore raw

Hello!

The following patch is making the get_empty_super() function just local to the place where it's only use is and where it's only use should be: fs/super.c

The removal of this symbol from ksyms.c should:

1. Help making the module interface cleaner by a tinny margin :-).

2. shouldn't hurt anything sane.

Please apply... line sloops in the patch are due to bla bla, and don't hurt...

Thank's

Signature · 4 lines
- phone: +49 214 8656 283
- job:   eVision-Ventures AG, LEV .de (MY OPINIONS ARE MY OWN!)
- langs: de_DE.ISO8859-1, en_US, pl_PL.ISO8859-2, last ressort:
ru_RU.KOI8-R
fs/super.c +1 -1
diff -ur linux/fs/super.c new/fs/super.c
@@ -691,7 +691,7 @@
  *	the request.
  */
  
-struct super_block *get_empty_super(void)
+static struct super_block *get_empty_super(void)
 {
 	struct super_block *s;
include/linux/fs.h +0 -1
diff -ur linux/include/linux/fs.h new/include/linux/fs.h
@@ -1291,7 +1285,6 @@
 
 extern struct file_system_type *get_fs_type(const char *name);
 extern struct super_block *get_super(kdev_t);
-struct super_block *get_empty_super(void);
 extern void put_super(kdev_t);
 unsigned long generate_cluster(kdev_t, int b[], int);
 unsigned long generate_cluster_swab32(kdev_t, int b[], int);
kernel/ksyms.c +0 -1
diff -ur linux/kernel/ksyms.c new/kernel/ksyms.c
@@ -129,7 +129,6 @@
 EXPORT_SYMBOL(update_atime);
 EXPORT_SYMBOL(get_fs_type);
 EXPORT_SYMBOL(get_super);
-EXPORT_SYMBOL(get_empty_super);
 EXPORT_SYMBOL(getname);
 EXPORT_SYMBOL(names_cachep);
 EXPORT_SYMBOL(fput);
#1 lore raw
Quoted 1 line · Martin Dalecki

1. Help making the module interface cleaner by a tinny margin :-).

You only help changing the API during a stable[1] series. Wait until 2.5 for this.

API cannot change during stable series. (ABI can, BTW)

So lets just forget about this, ok ;-)

Regards

Ingo Oeser

[1] By stable I mean "marked as the stable branch" not the actual behavior >;)

Signature · 2 lines
10.+11.03.2001 - 3. Chemnitzer LinuxTag <http://www.tu-chemnitz.de/linux/tag>
         <<<<<<<<<<<<     been there and had much fun   >>>>>>>>>>>>
#2 lore raw
Quoted 9 lines · Ingo Oeser
Quoted 1 line · Martin Dalecki

1. Help making the module interface cleaner by a tinny margin :-).

You only help changing the API during a stable[1] series. Wait until 2.5 for this.

API cannot change during stable series. (ABI can, BTW)

So lets just forget about this, ok ;-)

Wrong answer: AV already did it (static get_empty_super) in 2.4.4-pre4.

Hugh

author
#3 lore raw
In reply to Martin Dalecki
Quoted 9 lines · Ingo Oeser
Quoted 1 line · Martin Dalecki

1. Help making the module interface cleaner by a tinny margin :-).

You only help changing the API during a stable[1] series. Wait until 2.5 for this.

API cannot change during stable series. (ABI can, BTW) So lets just forget about this, ok ;-)

So just show me one module using this function in a non-broken way!