Skip to contentSkip to conversation

Remove silly beep macro from pgtable.h

PATCH In review Jeff Golds 3 participants 4 messages May 15, 2001 – May 16, 2001

lore
Share & tools
lore

Jeff Golds

author
#0 lore raw

PATCH 1/1 Remove silly beep macro from pgtable.h

Hi folks,

Found this bit of unused code in the i386 and sh architectures. As it's not being used, let's get rid of it. Also, pgtable.h seems to be an odd place for this.

-Jeff

include/asm-i386/pgtable.h Tue May 15 09:12:24 2001 renamed from include/asm-i386/pgtable.h Fri Apr 27 15:48:21 2001 +0 -2
diff -u -r linux-2.4.4.pure/include/asm-i386/pgtable.h linux-2.4.4/include/asm-i386/pgtable.h
@@ -110,8 +110,6 @@
 #endif
 #endif
 
-#define __beep() asm("movb $0x3,%al; outb %al,$0x61")
-
 #define PMD_SIZE       (1UL << PMD_SHIFT)
 #define PMD_MASK       (~(PMD_SIZE-1))
 #define PGDIR_SIZE     (1UL << PGDIR_SHIFT)
include/asm-sh/pgtable.h Tue May 15 09:35:29 2001 renamed from include/asm-sh/pgtable.h Wed Apr 11 21:24:52 2001 +0 -2
diff -u -r linux-2.4.4.pure/include/asm-sh/pgtable.h linux-2.4.4/include/asm-sh/pgtable.h
@@ -72,8 +72,6 @@
 
 #include <asm/pgtable-2level.h>
 
-#define __beep() asm("")
-
 #define PMD_SIZE       (1UL << PMD_SHIFT)
 #define PMD_MASK       (~(PMD_SIZE-1))
 #define PGDIR_SIZE     (1UL << PGDIR_SHIFT)
Signature · 2 lines
Jeff Golds
[email protected]
#1 lore raw
Quoted 3 lines · Jeff Golds

Hi folks,

Found this bit of unused code in the i386 and sh architectures. As it's not being used, let's get rid of it. Also, pgtable.h seems to be an odd place for this.

I'd leave it.. folks with early boot troubles might find it useful.

-Mike

#2 lore raw
Quoted 10 lines · Mike Galbraith
Quoted 4 lines · Jeff Golds

Hi folks,

Found this bit of unused code in the i386 and sh architectures.
As it's not being used, let's get rid of it. Also, pgtable.h seems to be an odd place for this.

I'd leave it.. folks with early boot troubles might find it useful.

-Mike

Consider small rant about literal IO references to magic locations hereby ranted. Especially in header files completely unrelated to the IO function in question.

-#define __beep() asm("movb $0x3,%al; outb %al,$0x61")

Let's please not assume that every i386 implementation has a full set of legacy PC IO hardware.

Signature · 1 line
/Jonathan Lundell.
#3 lore raw
Quoted 13 lines · Jonathan Lundell
Quoted 11 lines · Mike Galbraith
Quoted 5 lines · Jeff Golds

Hi folks,

Found this bit of unused code in the i386 and sh architectures.
As it's not being used, let's get rid of it. Also, pgtable.h seems to be an odd place for this.

I'd leave it.. folks with early boot troubles might find it useful.

-Mike

Quoted 8 lines

Consider small rant about literal IO references to magic locations hereby ranted. Especially in header files completely unrelated to the IO function in question.

-#define __beep() asm("movb $0x3,%al; outb %al,$0x61")

Let's please not assume that every i386 implementation has a full set of legacy PC IO hardware.

Is there a generic form of hello() that could be tucked away somewhere?

-Mike