Skip to contentSkip to conversation

[2.4.5] buz.c won't compile

DISCUSSION Jan Sembera 5 participants 7 messages May 26, 2001 – May 29, 2001

lore
Share & tools
lore
#0 lore raw

Hi,

i've got a problem compiling drivers/media/video/buz.c as module. When i'm trying to compile, i get couple of errors:

gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE -DMODVERSIONS -include /usr/src/linux/include/linux/modversions.h -c -o buz.o buz.c
buz.c: In function `v4l_fbuffer_alloc':
buz.c:188: `KMALLOC_MAXSIZE' undeclared (first use in this function) buz.c:188: (Each undeclared identifier is reported only once buz.c:188: for each function it appears in.)
buz.c: In function `jpg_fbuffer_alloc':
buz.c:262: KMALLOC_MAXSIZE' undeclared (first use in this function) buz.c:256: warning: alloc_contig' might be used uninitialized in this function buz.c: In function `jpg_fbuffer_free':
buz.c:322: KMALLOC_MAXSIZE' undeclared (first use in this function) buz.c:316: warning: alloc_contig' might be used uninitialized in this function buz.c: In function `zoran_ioctl':
buz.c:2837: KMALLOC_MAXSIZE' undeclared (first use in this function) buz.c: In function zr36057_init':
buz.c:3215: too few arguments to function `video_register_device_Recfe1c4b' make[3]: *** [buz.o] Error 1
make[3]: Leaving directory `/usr/src/linux/drivers/media/video' make[2]: *** [_modsubdir_video] Error 2
make[2]: Leaving directory `/usr/src/linux/drivers/media'
make[1]: *** [_modsubdir_media] Error 2
make[1]: Leaving directory `/usr/src/linux/drivers'
make: *** [_mod_drivers] Error 2

Jan Sembera

#1 lore raw
Quoted 2 lines

i've got a problem compiling drivers/media/video/buz.c as module. When i'm trying to compile, i get couple of errors:

If you need buz support you need -ac

#2 lore raw
In reply to Jan Sembera
Quoted 2 lines · Jan Sembera

i've got a problem compiling drivers/media/video/buz.c as module. When i'm trying to compile, i get couple of errors:

...

Actually, it broke at 2.4.3. Go look at the first change to buz.c from that patch.

--Ricky

PS: I really hate it when people break "functional" things in the "stable"
tree. (functional and stable are both open to debate.)

PPS: Yes, I know Linus doesn't bother compling most of the stuff :-)

#3 lore raw
Quoted 2 lines

Actually, it broke at 2.4.3. Go look at the first change to buz.c from that patch.

None at all. It didn't break at 2.4.3, it just didn't compile at all anymore in 2.4.3. It was already kind of broken before that.

Quoted 2 lines

PS: I really hate it when people break "functional" things in the >"stable" tree. (functional and stable are both open to debate.)

Nobody broke it. The fact that it didn't compile right was something nobody ever looked at - it was already broken before and I really don't suppose anyone uses it.
The words "if it compiles, it'll work" are not true. Really.

Ronald

PS, how about just removing it from the kernel? Would spare a lot of troubles, and nobody uses it anyway :-).

#4 lore raw
In reply to Ricky Beam
Quoted 2 lines · Ricky Beam

PS: I really hate it when people break "functional" things in the "stable"
tree. (functional and stable are both open to debate.)

I was under the impression that it really wasn't functional.

mrc

Signature · 4 lines
       Mike Castle       Life is like a clock:  You can work constantly
  [email protected]  and be right all the time, or not work at all
www.netcom.com/~dalgoda/ and be right at least twice a day.  -- mrc
    We are all of us living in the shadow of Manhattan.  -- Watchmen
#5 lore raw
In reply to Ricky Beam
Quoted 2 lines

Actually, it broke at 2.4.3. Go look at the first change to buz.c from that patch.

buz was broken before 2.4.0

Quoted 2 lines

PS: I really hate it when people break "functional" things in the "stable"
tree. (functional and stable are both open to debate.)

buz was never functional in 2.4

#6 lore raw
Quoted 4 lines · Alan Cox
Quoted 2 lines

Actually, it broke at 2.4.3. Go look at the first change to buz.c from that patch.

buz was broken before 2.4.0

Where "broke" is defined as "no longer compiles".

(I'm one of those nuts that compiles everything.)

--Ricky