net
Quoted 4 lines
Quoted 4 lines
(quoted diff) +0
-0@@ -643,9 +631,7 @@ eexp_hw_tx_pio(dev,data,length); } dev_kfree_skb(buf);
Quoted 8 lines
Review line 636
Quoted 5 lines
(quoted diff) +0
-2-#ifdef CONFIG_SMP spin_unlock_irqrestore(&lp->lock, flags); -#endif enable_irq(dev->irq); return 0;They are done this way to get good non SMP performance. Your changes would ruin that.
I think the spin_lock could be removed on SMP, too.
Concurrent xmit & timeout calls are prevented by core network code, and concurrent interrupts are prevented by disable_irq().
Or replace spin_lock_irqsave() with spin_lock().
--
Manfred