Skip to contentSkip to conversation

timer vector printed inconsistently

PATCH New Philip Pokorny 1 participant 1 message Jun 6, 2001

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 timer vector printed inconsistently

When trying to debug a recent problem with some interrupt routing, I found the output to be confusing... The TIMER vector is printed with %d, but when the APIC tables are printed, the vector is printed using %02X. This was particularly confusing in this case because the TIMER vector was 49d (0x31) and vector 0x49 was assigned to a different APIC pin.

The following patch causes the TIMER vector to be printed the same way as the vectors in the APIC table (See line 786 of my io_apic.c)

I'm not a subscriber of the kernel mailing list, so please CC my on any replies.

i386/kernel/io_apic.c renamed from i386/kernel/io_apic.c.orig +1 -1
@@ -1489,7 +1489,7 @@
 	pin1 = find_isa_irq_pin(0, mp_INT);
 	pin2 = find_isa_irq_pin(0, mp_ExtINT);
 
-	printk(KERN_INFO "..TIMER: vector=%d pin1=%d pin2=%d\n", vector, pin1, pin2);
+	printk(KERN_INFO "..TIMER: vector=%02X pin1=%d pin2=%d\n", vector, pin1, pin2);
 
 	if (pin1 != -1) {
 		/*
Signature · 4 lines
Philip Pokorny, Senior Engineer
http://www.penguincomputing.com

Penguin Computing - The World's Most Reliable Linux Systems