Skip to contentSkip to conversation

to init/main.c

PATCH In review Daniel Dickman 3 participants 3 messages Jun 16, 2001

lore
Share & tools
lore

Daniel Dickman

author
#0 lore raw

PATCH 1/1 to init/main.c

Here is a small patch to main.c.

It does the following:
- makes sure that asm/mtrr.h actually gets included, and
- changes formatting in one place as per Documentation/CodingStyle

init/main.c Sat Jun 16 11:48:42 2001 renamed from init/main.c Tue May 22 12:35:42 2001 +0 -0
@@ -50,7 +50,7 @@

#endif

#ifdef CONFIG_MTRR
-# include <asm/mtrr.h>
+#include <asm/mtrr.h>
#endif

#ifdef CONFIG_NUBUS
@@ -292,8 +292,7 @@

       ROOT_DEV = name_to_kdev_t(line);
       memset (root_device_name, 0, sizeof root_device_name);
       if (strncmp (line, "/dev/", 5) == 0) line += 5;
-       for (i = 0; i < sizeof root_device_name - 1; ++i)
-       {
+       for (i = 0; i < sizeof root_device_name - 1; ++i) {
           ch = line[i];
           if ( isspace (ch) || (ch == ',') || (ch == '\0') ) break;
           root_device_name[i] = ch;
#1 lore raw
Quoted 8 lines · Daniel Dickman

Here is a small patch to main.c.

It does the following:
- makes sure that asm/mtrr.h actually gets included, and

init/main.c Sat Jun 16 11:48:42 2001 line 54

Quoted 6 lines
init/main.c Sat Jun 16 11:48:42 2001 renamed from init/main.c Tue May 22 12:35:42 2001 +1 -1
@@ -50,7 +50,7 @@
 #endif
 
 #ifdef CONFIG_MTRR
-#  include <asm/mtrr.h>
+#include <asm/mtrr.h>
 #endif

huh?

There is absolutely nothing wrong with that include line.

Signature · 3 lines
Jeff Garzik      | Andre the Giant has a posse.
Building 1024    |
MandrakeSoft     |
#2 lore raw
In reply to Daniel Dickman
Quoted 4 lines · Daniel Dickman

Here is a small patch to main.c.

It does the following:
- makes sure that asm/mtrr.h actually gets included, and

What the hell is this? It is already included!

init/main.c Sat Jun 16 11:48:42 2001 line 56

Quoted 13 lines

- changes formatting in one place as per Documentation/CodingStyle

init/main.c Sat Jun 16 11:48:42 2001 renamed from init/main.c Tue May 22 12:35:42 2001 +1 -1
@@ -50,7 +50,7 @@
 #endif
 
 #ifdef CONFIG_MTRR
-#  include <asm/mtrr.h>
+#include <asm/mtrr.h>
 #endif
 
 #ifdef CONFIG_NUBUS

I don't want this change. It's not fixing anything and removes the intentional indentation.

And was there a reason not to Cc: me?

				Regards,

					Richard....
Permanent: [email protected]
Current:   [email protected]