REPOST by request: String literal patch (was Re: 2.4.7 -- GCC-3.0 -- "multiline string literals deprecated" -- PATCH)
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 9 lines
Folks,
While building both kernels 2.4.6 and 2.4.7,
I encountered a series of compiler warnings,warning: multiline string literals are deprecated.
The build environment was gcc3.0 and binutils-2.11.2.
---------------------<etc>----------------
Quoted 8 lines
Quoted 7 lines · Pete Zaitcev
Quoted 7 lines
Content-Type: application/octet-stream;
name="checksum.h.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="checksum.h.patch"
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
LS0tIGxpbnV4L2luY2x1ZGUvYXNtLWkzODYvY2hlY2tzdW0uaC5vcmlnCVNhdCBKdWwgMjgg MTM6NDM6MTYgMjAwMQorKysgbGludXgvaW5jbHVkZS9hc20taTM4Ni9jaGVja3N1bS5oCVNh
How am I supposed to review this?
Besides, why did you sent THREE patches
instead of one?-- Pete
Reposted in plain english... was Netscape
attachment. Many many lines...
--------- cut here ----------- cut here ---------- cut here -----
include/asm-i386/floppy.h renamed from include/asm-i386/floppy.h.orig +22 -22
@@ -75,28 +75,28 @@#ifndef NO_FLOPPY_ASSEMBLER __asm__ ( -"testl %1,%1 - je 3f -1: inb %w4,%b0 - andb $160,%b0 - cmpb $160,%b0 - jne 2f - incw %w4 - testl %3,%3 - jne 4f - inb %w4,%b0 - movb %0,(%2) - jmp 5f -4: movb (%2),%0 - outb %b0,%w4 -5: decw %w4 - outb %0,$0x80 - decl %1 - incl %2 - testl %1,%1 - jne 1b -3: inb %w4,%b0 -2: " +" testl %1,%1\n" +" je 3f\n" +"1: inb %w4,%b0\n" +" andb $160,%b0\n" +" cmpb $160,%b0\n" +" jne 2f\n" +" incw %w4\n" +" testl %3,%3\n" +" jne 4f\n" +" inb %w4,%b0\n" +" movb %0,(%2)\n" +" jmp 5f\n" +"4: movb (%2),%0\n" +" outb %b0,%w4\n" +"5: decw %w4\n" +" outb %0,$0x80\n" +" decl %1\n" +" incl %2\n" +" testl %1,%1\n" +" jne 1b\n" +"3: inb %w4,%b0\n" +"2:" :"=a" ((char ) st),"=c" ((long ) virtual_dma_count), "=S" ((long) virtual_dma_addr)
arch/i386/kernel/semaphore.c renamed from arch/i386/kernel/semaphore.c.orig +56 -56
141 lines not on this page · raw message
--------- cut here ----------- cut here ---------- cut here -----
Signature · 7 lines
*********************************************
Paul Reich RF/Microwave Engineer
Support the "Freedom To Innovate"...
Just say "No".
*********************************************Quoted 5 lines · Pete Zaitcev
Quoted 5 lines
Date: Tue, 31 Jul 2001 23:32:21 -0500
From: paulr <[email protected]>
To: Pete Zaitcev <[email protected]>
CC: [email protected]
---------------------<etc>---------------------
Quoted 15 lines
arch/i386/kernel/semaphore.c Sat Jul 28 14:50:50 2001 line 186
Quoted 11 lines
arch/i386/kernel/semaphore.c Sat Jul 28 14:50:50 2001 renamed from arch/i386/kernel/semaphore.c.orig Sat Jul 28 13:57:29 2001 +3
-2@@ -181,56 +181,56 @@ ".text\n" ".align 4\n" ".globl __down_failed\n" -"__down_failed:\n\t" - "pushl %eax\n\t" +"__down_failed:\n" +" pushl %eax\n" +" pushl %edx\n"Why did you replace this? It was not a multi-line literal. It it triggered a warning, I'd suspect the gcc.
Quoted 1 line
-- Pete
Pete,
There was no operational or gcc-3.0 compiler
issue with the above stanza.
I altered this section only only to indent and align the text. My choice was Purely Esthetic(TM).
It worked fine either way, 'specially on a GHz
althlon ;-)
Regards,
Paul
Signature · 7 lines
*********************************************
Paul Reich RF/Microwave Engineer
Support the "Freedom To Innovate"...
Just say "No".
*********************************************