small SCSI use count fix

PATCH New Tim Hockin 1 participant 1 message Aug 14, 2001 SCSI

Share & tools

Tim Hockin

author

2001-08-14 04:39 UTC #0 lore raw

PATCH 1/1 small SCSI use count fix

Attached is a small fix to increment the use count in scsi_register_host() before we start working with it - prevent false decrementing. (from one of the crew here ;)

Please let me know if there is any reason this shouldn't go mainline in the next 2.4.x.

thanks
Tim

Signature · 4 lines

Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
[email protected]

drivers/scsi/scsi.c +2 -2

diff -ruN dist+patches-2.4.8/drivers/scsi/scsi.c cobalt-2.4.8/drivers/scsi/scsi.c
@@ -1835,6 +1828,8 @@
 
 	pcount = next_scsi_host;
 
+	MOD_INC_USE_COUNT;
+
 	/* The detect routine must carefully spinunlock/spinlock if 
 	   it enables interrupts, since all interrupt handlers do 
 	   spinlock as well.

@@ -1964,8 +1965,6 @@
 	       (scsi_init_memory_start - scsi_memory_lower_value) / 1024,
 	       (scsi_memory_upper_value - scsi_init_memory_start) / 1024);
 #endif
-
-	MOD_INC_USE_COUNT;
 
 	if (out_of_space) {
 		scsi_unregister_host(tpnt);	/* easiest way to clean up?? */