Skip to contentSkip to conversation

some fixups for ppc405_enet init code

PATCH In review andrew may 2 participants 2 messages Sep 8, 2001 – Sep 10, 2001 Network drivers

lore
Share & tools
lore

andrew may

author
#0 lore raw

PATCH 1/1 some fixups for ppc405_enet init code

This change is for Config.in and the Makefile to add the ppc405_enet driver.

I also removed the _probe1 function and moved the code down into the init function. This was done for 2 reasons: 1 the dev->name is not know until the device is registered and 2 so the code would be removed after init.

I also added a kfree of the private data when the register fails and when the module is removed.

drivers/net/Config.in +1 -1
diff -ur linux-bk/drivers/net/Config.in linux-bk-local/drivers/net/Config.in
@@ -42,7 +42,7 @@
       tristate '  Symbios 53c885 (Synergy ethernet) support' CONFIG_NCR885E
       tristate '  National DP83902AV (Oak ethernet) support' CONFIG_OAKNET
       if [ "$CONFIG_405GP" = "y" ]; then
-        bool '  PowerPC 405 on-chip ethernet' CONFIG_PPC405_ENET
+        tristate '  PowerPC 405 on-chip ethernet' CONFIG_PPC405_ENET
         if [ "$CONFIG_PPC405_ENET" = "y" ]; then
           int  '    PHY Address' CONFIG_PPC405_ENET_PHY_ADDR 1
           bool '    Include extended error messages' CONFIG_PPC405_ENET_ERROR_MSG n
drivers/net/Makefile +1 -0
diff -ur linux-bk/drivers/net/Makefile linux-bk-local/drivers/net/Makefile
@@ -205,6 +205,7 @@
 obj-$(CONFIG_MAC89x0) += mac89x0.o
 obj-$(CONFIG_TUN) += tun.o
 obj-$(CONFIG_DL2K) += dl2k.o
+obj-$(CONFIG_PPC405_ENET) += ppc405_enet.o
 
 ifeq ($(CONFIG_ARCH_ACORN),y)
 mod-subdirs	+= ../acorn/net
drivers/net/ppc405_enet.c +61 -66

154 lines not on this page · raw message

#1 lore raw
Quoted 9 lines · andrew may

This change is for Config.in and the Makefile to add the ppc405_enet driver.

I also removed the _probe1 function and moved the code down into the init function. This was done for 2 reasons: 1 the dev->name is not know until the device is registered and 2 so the code would be removed after init.

Quoted 7 lines

I also added a kfree of the private data when the register fails and when the module is removed.

------------------------------------------------------------------------

ppc_enet.diffName: ppc_enet.diff
Type: Plain Text (text/plain)

Thanks, I'll make the appropriate changes.

-- armin

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/