Skip to contentSkip to conversation

Possible change to ./scripts/split-include.c

PATCH Bob Miller 2 participants 2 messages Oct 8, 2001

lore
Share & tools
lore

Bob Miller

author
#0 lore raw

We are using CVS to keep track of the Linux kernels. I am trying to solve a problem where split-include clobbers our CVS directory under ./include/config. I made a small change to split-include.c that only finds files that are header files(.h). However, I am unsure of the history of split-include, and am concerned about possible side effects.

If this change is reasonable, could you consider merging it into future kernels. Attached is a diff -u for the change to split-include.c

Thanks,
Bob Miller
[email protected]

split-include.c renamed from split-include.c,orig +1 -1
@@ -188,7 +188,7 @@
      * So by having an initial \n, strstr will find exact matches.
      */
 
-    fp_find = popen("find * -type f -print", "r");
+    fp_find = popen("find * -type f -name \"*.h\" -print", "r");
     if (fp_find == 0)
 	ERROR_EXIT( "find" );
 
#1 lore raw
Quoted 3 lines · Bob Miller

If this change is reasonable, could you consider merging it into future kernels. Attached is a diff -u for the change to split-include.c

Looks reasonable to me - the only non-*.h files I find in the include directory seems to be automatically generated with no config information.

Linus