register_blkdev and unregister_blkdev
I was looking at the code for register_blkdev and unregister_blkdev. I found that no locking (spinlocks) are used to protect the blkdevs struture in these functions. I suspect we have not seen a problem till now since
Either
1. register_blkdev is called from modules, and only module initialization is protected.
2. register_blkdev is called during init time for drivers in the kernel and I am not sure about whether calls to register_blkdev at this time are implicitly
serialized, since only
1 CPU is active during initialization
Anway, what I needed to know was if (1) and (2) are enough to ensure safety in register_blkdev and unregister_blkdev.
May be I am missing something, there is already some lock which is held before these routines are invoked, I could not find any.
Comments
Thanks,
Balbir Singh.
----------------------------------------------------------------------------------------------------------------------
Information transmitted by this E-MAIL is proprietary to Wipro and/or its Customers and is intended for use only by the individual or entity to which it is addressed, and may contain information that is privileged, confidential or exempt from disclosure under applicable law. If you are not the intended recipient or it appears that this mail has been forwarded to you without proper authority, you are notified that any use or dissemination of this information in any manner is strictly prohibited. In such cases, please notify us immediately at mailto:[email protected] and delete this mail from your records.
----------------------------------------------------------------------------------------------------------------------
Quoted 5 lines · BALBIR SINGH
I was looking at the code for
register_blkdevandunregister_blkdev. I found that no
locking (spinlocks) are used to protect the blkdevs struture in these functions. I suspect
we have not seen a problem till now since
... they are only called under BKL; ditto for lookups in the tables they (de-)populate.
Quoted 8 lines · Alexander Viro
Quoted 4 lines
I was looking at the code for
register_blkdevandunregister_blkdev. I found that no locking (spinlocks) are used to protect the blkdevs struture in these functions. I suspect we have not seen a problem till now since... they are only called under BKL; ditto for lookups in the tables they (de-)populate.
What I wanted to know was, who is calling/holding the BKL? Is it because lock_kernel is called in sys_create_module() and sys_init_module().
I also looked at sd.c, it does not hold the BKL before calling register_blkdev() it calls devfs_register_blkdev() from sd_init().
Maybe I am still missing something.
Balbir
----------------------------------------------------------------------------------------------------------------------
Information transmitted by this E-MAIL is proprietary to Wipro and/or its Customers and is intended for use only by the individual or entity to which it is addressed, and may contain information that is privileged, confidential or exempt from disclosure under applicable law. If you are not the intended recipient or it appears that this mail has been forwarded to you without proper authority, you are notified that any use or dissemination of this information in any manner is strictly prohibited. In such cases, please notify us immediately at mailto:[email protected] and delete this mail from your records.
----------------------------------------------------------------------------------------------------------------------
Quoted 9 lines · BALBIR SINGH
Quoted 7 lines · Alexander Viro
Quoted 6 lines
I was looking at the code for
register_blkdevandunregister_blkdev. I found that no
locking (spinlocks) are used to protect the blkdevs struture in these functions. I suspect
we have not seen a problem till now since
Quoted 5 lines
Quoted 3 lines
... they are only called under BKL; ditto for lookups in the tables they (de-)populate.
What I wanted to know was, who is calling/holding the BKL? Is it because
lock_kernelis called insys_create_module()andsys_init_module().
All module init code is under BKL and will stay that way for a long time. If that ever becomes not true, we are in for much more pain that register_blkdev() races - you would need to do audit of all drivers to pull something like that.
Quoted 5 lines · Alexander Viro
All module init code is under BKL and will stay that way for a long time. If that ever becomes not true, we are in for much more pain that
register_blkdev()races - you would need to do audit of all drivers to pull something like that.
I suspected that the locking in init_module was preventing bad things from happening in {devfs_}register_blkdev, I am sure now.
Balbir
----------------------------------------------------------------------------------------------------------------------
Information transmitted by this E-MAIL is proprietary to Wipro and/or its Customers and is intended for use only by the individual or entity to which it is addressed, and may contain information that is privileged, confidential or exempt from disclosure under applicable law. If you are not the intended recipient or it appears that this mail has been forwarded to you without proper authority, you are notified that any use or dissemination of this information in any manner is strictly prohibited. In such cases, please notify us immediately at mailto:[email protected] and delete this mail from your records.
----------------------------------------------------------------------------------------------------------------------