Skip to contentSkip to conversation

is reparent_to_init a good thing to do?

DISCUSSION BALBIR SINGH 3 participants 6 messages Oct 9, 2001 – Oct 11, 2001

lore
Share & tools
lore
#0 lore raw

I was looking at the driver under drivers/net/8139too.c, a kernel thread rtl8139_thread is created, it calls daemonize() and soon afterwards calls reparent_to_init(). Looking at reparent_to_init(), it looks like all kernel threads should do this. But, I feel I am missing something, since not everybody does this.

Is this a good thing to do? or are there special cases when we need this.

Balbir

----------------------------------------------------------------------------------------------------------------------
Information transmitted by this E-MAIL is proprietary to Wipro and/or its Customers and is intended for use only by the individual or entity to which it is addressed, and may contain information that is privileged, confidential or exempt from disclosure under applicable law. If you are not the intended recipient or it appears that this mail has been forwarded to you without proper authority, you are notified that any use or dissemination of this information in any manner is strictly prohibited. In such cases, please notify us immediately at mailto:[email protected] and delete this mail from your records.
----------------------------------------------------------------------------------------------------------------------

#1 lore raw
Quoted 9 lines · BALBIR SINGH

I was looking at the driver under drivers/net/8139too.c, a kernel thread rtl8139_thread is created, it calls daemonize() and soon afterwards calls reparent_to_init(). Looking at reparent_to_init(), it looks like all kernel threads should do this. But, I feel I am missing something, since not everybody does this.

Is this a good thing to do? or are there special cases when we need this.

I think yes, more kernel threads need to use this function. Most particularly, threads which are parented by a userspace application and which can terminate. For example, the nfsd threads.

Right now, it's probably the case that nfsd threads will turn into zombies when they terminate, *if* their parent is still
running. But of course, most kernel threads are parented
by very short-lived userspace applications, so nobody has ever noticed.

#2 lore raw
In reply to BALBIR SINGH
Quoted 9 lines · Andrew Morton

I think yes, more kernel threads need to use this function. Most particularly, threads which are parented by a userspace application and which can terminate. For example, the nfsd threads.

Right now, it's probably the case that nfsd threads will turn into zombies when they terminate, *if* their parent is still
running. But of course, most kernel threads are parented
by very short-lived userspace applications, so nobody has ever noticed.

Or long lived kernel threads from short lived login sessions.

You have a headless gateway box for your local subnet, administered via ssh from a machine on the local subnet. So you SSH into the box through eth1, ifconfig eth0 down back up again. If eth0 is an rtl8039too, this fires off a kernel thread (which, before reparent_to_init, was parented to your ssh login session).

Now exit the login session. SSH does not exit until all the child processes exit, so it just hangs there until you kill it from another console window...

Rob

#3 lore raw
In reply to BALBIR SINGH
Quoted 8 lines · Rob Landley

Or long lived kernel threads from short lived login sessions.

You have a headless gateway box for your local subnet, administered via ssh from a machine on the local subnet. So you SSH into the box through eth1, ifconfig eth0 down back up again. If eth0 is an rtl8039too, this fires off a kernel thread (which, before reparent_to_init, was parented to your ssh login session).

Now exit the login session. SSH does not exit until all the child processes exit, so it just hangs there until you kill it from another console window...

Rob

The question one can ask is what should a thread do then? Should reparent_to_init() send a SIGCHLD to the process/task that was parent before init became the parent? this should be easy to do, but will this fix the problem? I think so.

I can patch up something soon, if somebody is willing to test it.

comments,
Balbir

----------------------------------------------------------------------------------------------------------------------
Information transmitted by this E-MAIL is proprietary to Wipro and/or its Customers and is intended for use only by the individual or entity to which it is addressed, and may contain information that is privileged, confidential or exempt from disclosure under applicable law. If you are not the intended recipient or it appears that this mail has been forwarded to you without proper authority, you are notified that any use or dissemination of this information in any manner is strictly prohibited. In such cases, please notify us immediately at mailto:[email protected] and delete this mail from your records.
----------------------------------------------------------------------------------------------------------------------

#4 lore raw
In reply to BALBIR SINGH
Quoted 8 lines · Balbir Singh
Quoted 6 lines · Rob Landley

Or long lived kernel threads from short lived login sessions.

You have a headless gateway box for your local subnet, administered via ssh from a machine on the local subnet. So you SSH into the box through eth1, ifconfig eth0 down back up again. If eth0 is an rtl8039too, this fires off a kernel thread (which, before reparent_to_init, was parented to your ssh login session).

Now exit the login session. SSH does not exit until all the child processes exit, so it just hangs there until you kill it from another console window...

Quoted 8 lines
Quoted 2 lines

Rob

The question one can ask is what should a thread do then? Should reparent_to_init() send a SIGCHLD to the process/task that was parent before init became the parent? this should be easy to do, but will this fix the problem? I think so.

I can patch up something soon, if somebody is willing to test it.

Ooh! sorry this is a wrong approach to send SIGCHLD to the previous parent. AFAIK, all shells send their children SIGHUP when the shell exits, but SSH may have some special security consideration in waiting for all children to exit, does anyone know?

Balbir

Quoted 6 lines

comments,
Balbir

----------------------------------------------------------------------------------------------------------------------
Information transmitted by this E-MAIL is proprietary to Wipro and/or its Customers and is intended for use only by the individual or entity to which it is addressed, and may contain information that is privileged, confidential or exempt from disclosure under applicable law. If you are not the intended recipient or it appears that this mail has been forwarded to you without proper authority, you are notified that any use or dissemination of this information in any manner is strictly prohibited. In such cases, please notify us immediately at mailto:[email protected] and delete this mail from your records.
----------------------------------------------------------------------------------------------------------------------

#5 lore raw
In reply to BALBIR SINGH
Quoted 3 lines · BALBIR SINGH
Quoted 2 lines · Balbir Singh
Quoted 1 line · Rob Landley

Or long lived kernel threads from short lived login sessions.

...

Quoted 6 lines

Ooh! sorry this is a wrong approach to send SIGCHLD to the previous parent. AFAIK, all shells send their children SIGHUP when the shell exits, but SSH may have some special security consideration in waiting for all children to exit, does anyone know?

Balbir

The problem I mentioned above was the reason "reparent_to_init" was created in the first place. Here it is in the archive:

http://www.uwsg.iu.edu/hypermail/linux/kernel/0105.0/0045.html

I.E. already fixed...

Google could probably find Jimmy Hoffa given half a chance... (If we could just figure out how to connect it up to maps.yahoo.com...)

Rob