Kernel patch for cls_u32.c
Subsystems (2)
To solve a problem while listing filters you may add this patch. It works for all kernel versions from 2.4.6 to 2.4.11 It wold be cool to have it in the next kernel release.
---
net/sched/cls_u32.c Wed Jul 11 23:55:23 2001 renamed from linux/net/sched/cls_u32.c Thu Feb 1 23:06:10 2001 +4 -2
@@ -613,7 +613,8 @@ for (ht = tp_c->hlist; ht; ht = ht->next) { if (arg->count >= arg->skip) { - if (arg->fn(tp, (unsigned long)ht, arg) < 0) { + if (ht == tp->root && + arg->fn(tp, (unsigned long)ht, arg) < 0) { arg->stop = 1; return; }
@@ -625,7 +626,8 @@ arg->count++; continue; } - if (arg->fn(tp, (unsigned long)n, arg) < 0) { + if (ht == tp->root && + arg->fn(tp, (unsigned long)n, arg) < 0) { arg->stop = 1; return; }
---
From: Thierry Coutelier <[email protected]>
Date: Wed, 10 Oct 2001 14:06:03 +0200
To solve a problem while listing filters you may add this patch. It works for all kernel versions from 2.4.6 to 2.4.11 It wold be cool to have it in the next kernel release.
What is the "problem"? Why should it only call the walker function on entries which equal tp->root? This change doesn't make any sense to me.
You need to describe the problem and how your changes solve that problem.
Franks a lot,
David S. Miller
[email protected]
Quoted 19 lines · Thierry Coutelier
To solve a problem while listing filters you may add this patch. It works for all kernel versions from 2.4.6 to 2.4.11 It wold be cool to have it in the next kernel release.
---
diff -ur2.4.6/linux/net/sched/cls_u32.clinux/net/sched/cls_u32.cnet/sched/cls_u32.c Wed Jul 11 23:55:23 2001 renamed from linux/net/sched/cls_u32.c Thu Feb 1 23:06:10 2001 +2
-1@@ -613,7 +613,8 @@ for (ht = tp_c->hlist; ht; ht = ht->next) { if (arg->count >= arg->skip) { - if (arg->fn(tp, (unsigned long)ht, arg) < 0) { + if (ht == tp->root && + arg->fn(tp, (unsigned long)ht, arg) < 0) { arg->stop = 1; return; }
net/sched/cls_u32.c Wed Jul 11 23:55:23 2001 line 633
Quoted 9 lines
net/sched/cls_u32.c Wed Jul 11 23:55:23 2001 renamed from linux/net/sched/cls_u32.c Thu Feb 1 23:06:10 2001 +2
-1@@ -625,7 +626,8 @@ arg->count++; continue; } - if (arg->fn(tp, (unsigned long)n, arg) < 0) { + if (ht == tp->root && + arg->fn(tp, (unsigned long)n, arg) < 0) { arg->stop = 1; return; }
Yeuch! The author of this code REALLY needs to read Documentation/CodingStyle
Indentation by 1 (!) single space is by far the ugliest thing I've seen so far.
/David Weinehall
_ _
// David Weinehall <[email protected]> /> Northern lights wander \\
// Project MCA Linux hacker // Dance across the winter sky // \> http://www.acc.umu.se/~tao/ </ Full colour fire </