Skip to contentSkip to conversation

Various patches against linuxppc_dev-2.4.14-pre7

PATCH In review David Müller (ELSOFT AG) 3 participants 4 messages Nov 2, 2001 – Nov 5, 2001

lore
Share & tools
lore

David Müller (ELSOFT AG)

author
#0 lore raw

PATCH 1/1 Various patches against linuxppc_dev-2.4.14-pre7

Hello

The attached patch fixes the following issues:

- include/asm-ppc/ibm4xx.h
missing include file (I'm not sure if this is the correct fix)

- drivers/net/ppc405_enet.h
missing include file (ditto)

- arch/ppc/kernel/ppc4xx_setup.c
added call to board_setup_irq() in ppc4xx_init_IRQ() added call to board_setup_rtc_access() in platform_init()

- arch/ppc/kernel/walnut.c
- arch/ppc/kernel/redwood.c
- arch/ppc/kernel/cpci405.c
- arch/ppc/kernel/ep405.c
added necessary board_setup_irq() and
board_setup_rtc_access() functions

Dave

#1 lore raw
Quoted 5 lines · David M?ller (ELSOFT AG)

- include/asm-ppc/ibm4xx.h
missing include file (I'm not sure if this is the correct fix)

- drivers/net/ppc405_enet.h
missing include file (ditto)

What's broken right now? <asm/ibm405gp.h> gets included by CONFIG_FOO, if FOO is a 405GP board.

Quoted 10 lines

- arch/ppc/kernel/ppc4xx_setup.c
added call to board_setup_irq() in ppc4xx_init_IRQ() added call to board_setup_rtc_access() in platform_init()

- arch/ppc/kernel/walnut.c
- arch/ppc/kernel/redwood.c
- arch/ppc/kernel/cpci405.c
- arch/ppc/kernel/ep405.c
added necessary board_setup_irq() and
board_setup_rtc_access() functions

Shouldn't board_setup_rtc_access() do all of the RTC stuff, not just changing the nvram bits? If your board needs a different way to get nvram access, we should rename board_setup_rtc_access() to board_setup_nvram_access()

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

author
#2 lore raw
Quoted 6 lines · Tom Rini
Quoted 3 lines · David M?ller (ELSOFT AG)

- include/asm-ppc/ibm4xx.h
missing include file (I'm not sure if this is the correct fix)

Quoted 6 lines
Quoted 3 lines

- drivers/net/ppc405_enet.h
missing include file (ditto)

What's broken right now? <asm/ibm405gp.h> gets included by CONFIG_FOO, if FOO is a 405GP board.

Sorry, my fault. I was a little bit too fast. ;-)

Quoted 15 lines
Quoted 7 lines

- arch/ppc/kernel/ppc4xx_setup.c
added call to board_setup_irq() in ppc4xx_init_IRQ() added call to board_setup_rtc_access() in platform_init()

Quoted 7 lines

- arch/ppc/kernel/walnut.c
- arch/ppc/kernel/redwood.c
- arch/ppc/kernel/cpci405.c
- arch/ppc/kernel/ep405.c
added necessary board_setup_irq() and
board_setup_rtc_access() functions

Quoted 6 lines

Shouldn't board_setup_rtc_access() do all of the RTC stuff, not just changing the nvram bits? If your board needs a different way to get nvram access, we should rename board_setup_rtc_access() to board_setup_nvram_access()

See attached patch

Dave

#3 lore raw
In reply to Tom Rini
Quoted 1 line · Tom Rini

Shouldn't board_setup_rtc_access() do all of the RTC stuff,

Please try to coordinate your RTC stuff with Armin. I don't have enough knowledge of the details to discuss this, and it appears there is a very standard way of working with the RTC, which is board specific.

	-- Dan

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/