Skip to contentSkip to conversation

problem with kernel 2.4.14 drivers/block/loop.c mm/swap.c

DISCUSSION Michel Valin 2 participants 2 messages Nov 9, 2001 Block layer

lore
Share & tools
lore
#0 lore raw

drivers/block/loop.c used by loopback filesystem code uses function

deactivate_page that was defined in mm/swap.c in kernel 2.4.13

deactivate_page seems to have been suppressed at kernel level 2.4.14 from
mm/swap.c

this results in missing entry point complaints when trying to load module loop.o
at kernel level 2.4.14

I am not knowledgeable about these modules and am not sure if or how loop.c and/or swap.c should be fixed

I could not find any other place to report theses findings either.

hoping that you can forward this to the proper person.

Signature · 4 lines
M.Valin
Recherche en Prevision Numerique
[email protected]
(514) 421-4753

begin:vcard
n:Valin;Michel
x-mozilla-html:FALSE
org:R.P.N.;Environnement Canada
adr:;;;;;;
version:2.1
email;internet:[email protected]
title:Analyste Principal / Senior Analyst
x-mozilla-cpt:;0
fn:Michel Valin
end:vcard

#1 lore raw
Quoted 8 lines · Michel Valin

drivers/block/loop.c used by loopback filesystem code uses function

deactivate_page that was defined in mm/swap.c in kernel 2.4.13

deactivate_page seems to have been suppressed at kernel level 2.4.14 from
mm/swap.c
...

This is a known bug.

The following patch fixes it:

drivers/block/loop.c +0 -2
@@ -207,7 +207,6 @@
 		index++;
 		pos += size;
 		UnlockPage(page);
-		deactivate_page(page);
 		page_cache_release(page);
 	}
 	return 0;
@@ -218,7 +217,6 @@
 	kunmap(page);
 unlock:
 	UnlockPage(page);
-	deactivate_page(page);
 	page_cache_release(page);
 fail:
 	return -1;

cu
Adrian

Signature · 3 lines
Get my GPG key: finger [email protected] | gpg --import

Fingerprint: B29C E71E FE19 6755 5C8A  84D4 99FC EA98 4F12 B400