Skip to contentSkip to conversation

loop back broken in 2.2.14

DISCUSSION Joe 6 participants 7 messages Nov 11, 2001 Block layer

lore
Share & tools
lore

Joe

author
#0 lore raw

compile 2.2.14.

Then

# modprobe -a loop
/lib/modules/2.4.14/kernel/drivers/block/loop.o: unresolved symbol
deactivate_page
/lib/modules/2.4.14/kernel/drivers/block/loop.o: insmod
/lib/modules/2.4.14/kernel/drivers/block/loop.o failed
/lib/modules/2.4.14/kernel/drivers/block/loop.o: insmod loop failed

do recursive grep through kernel tree:

# rgrep -rl  deactivate_page *
drivers/block/loop.c
drivers/block/loop.o

Is there a fix for this?

Joe

#1 lore raw
Quoted 11 lines · Joe

compile 2.2.14.

Then

# modprobe -a loop
/lib/modules/2.4.14/kernel/drivers/block/loop.o: unresolved symbol
deactivate_page
/lib/modules/2.4.14/kernel/drivers/block/loop.o: insmod
/lib/modules/2.4.14/kernel/drivers/block/loop.o failed
/lib/modules/2.4.14/kernel/drivers/block/loop.o: insmod loop failed
Quoted 7 lines

do recursive grep through kernel tree:

# rgrep -rl  deactivate_page *
drivers/block/loop.c
drivers/block/loop.o

Is there a fix for this?

yes, see 2.4.15pre1
warning, the iptables code in 2.4.15pre1 and pre2 seems broken.

François

#2 lore raw
In reply to Joe
Quoted 11 lines · Joe

compile 2.2.14.

Then

# modprobe -a loop
/lib/modules/2.4.14/kernel/drivers/block/loop.o: unresolved symbol
deactivate_page
/lib/modules/2.4.14/kernel/drivers/block/loop.o: insmod
/lib/modules/2.4.14/kernel/drivers/block/loop.o failed
/lib/modules/2.4.14/kernel/drivers/block/loop.o: insmod loop failed
Quoted 7 lines

do recursive grep through kernel tree:

# rgrep -rl  deactivate_page *
drivers/block/loop.c
drivers/block/loop.o

Is there a fix for this?

2.4.15-pre1 fixed this and there are also some patches on lkml-archives..

Signature · 3 lines
ElkOS: 10:35pm up  2:26, 3 users, load average: 0.05, 0.25, 0.30
bofhX: The data on your hard drive is out of balance.

#3 lore raw
In reply to Joe
Quoted 16 lines · François Cami
Quoted 13 lines · Joe

compile 2.2.14.

Then

# modprobe -a loop
/lib/modules/2.4.14/kernel/drivers/block/loop.o: unresolved symbol
deactivate_page
/lib/modules/2.4.14/kernel/drivers/block/loop.o: insmod
/lib/modules/2.4.14/kernel/drivers/block/loop.o failed
/lib/modules/2.4.14/kernel/drivers/block/loop.o: insmod loop failed

do recursive grep through kernel tree:

Quoted 8 lines
Quoted 5 lines
# rgrep -rl  deactivate_page *
drivers/block/loop.c
drivers/block/loop.o

Is there a fix for this?

yes, see 2.4.15pre1
warning, the iptables code in 2.4.15pre1 and pre2 seems broken.

and further it is likely that pre3 fixes iptables code :) (it looks like the patch got reverted)

Signature · 3 lines
Jeff Garzik      | Only so many songs can be sung
Building 1024    | with two lips, two lungs, and one tongue.
MandrakeSoft     |         - nomeansno
#4 lore raw
In reply to Joe
Quoted 11 lines · Joe

compile 2.2.14.

Then

# modprobe -a loop
/lib/modules/2.4.14/kernel/drivers/block/loop.o: unresolved symbol
deactivate_page
/lib/modules/2.4.14/kernel/drivers/block/loop.o: insmod
/lib/modules/2.4.14/kernel/drivers/block/loop.o failed
/lib/modules/2.4.14/kernel/drivers/block/loop.o: insmod loop failed
Quoted 7 lines

do recursive grep through kernel tree:

# rgrep -rl  deactivate_page *
drivers/block/loop.c
drivers/block/loop.o

Is there a fix for this?

This is a known bug.

The following patch fixes it:

drivers/block/loop.c +0 -2
@@ -207,7 +207,6 @@
 		index++;
 		pos += size;
 		UnlockPage(page);
-		deactivate_page(page);
 		page_cache_release(page);
 	}
 	return 0;
@@ -218,7 +217,6 @@
 	kunmap(page);
 unlock:
 	UnlockPage(page);
-	deactivate_page(page);
 	page_cache_release(page);
 fail:
 	return -1;
Quoted 1 line

Joe

cu
Adrian

Signature · 3 lines
Get my GPG key: finger [email protected] | gpg --import

Fingerprint: B29C E71E FE19 6755 5C8A  84D4 99FC EA98 4F12 B400
#5 lore raw
In reply to Joe
Quoted 7 lines · Jeff Garzik
Quoted 2 lines · François Cami

yes, see 2.4.15pre1
warning, the iptables code in 2.4.15pre1 and pre2 seems broken.

and further it is likely that pre3 fixes iptables code :) (it looks like the patch got reverted)

Actually it doesn't seem to be reverted,
just reworked -

I'll be testing it out -

cu

jjs

#6 lore raw
In reply to Joe
Quoted 4 lines · J Sloan
Quoted 2 lines · Jeff Garzik

François Cami wrote:

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

yes, see 2.4.15pre1
warning, the iptables code in 2.4.15pre1 and pre2 seems broken.

and further it is likely that pre3 fixes iptables code :) (it looks like the patch got reverted)

Actually it doesn't seem to be reverted,
just reworked -

hmm, spoke too soon -

looks like they were reverted after all...

cu

jjs