Skip to contentSkip to conversation

Possible bugs

DISCUSSION Bill Crawford 1 participant 1 message Dec 4, 2001 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 6 lines

Date: 02 Dec 2001 17:29:52 -0500
From: MIDN Sean Jones <[email protected]>
To: [email protected]

I was looking for code to cleanup and found these warnings:

...

Quoted 8 lines

agpgart_be.c:524: warning: `agp_generic_create_gatt_table' defined but not used
agpgart_be.c:652: warning: `agp_generic_free_gatt_table' defined but not used
agpgart_be.c:700: warning: `agp_generic_insert_memory' defined but not used
agpgart_be.c:758: warning: `agp_generic_remove_memory' defined but not used

...

Quoted 2 lines

Are these functions supposed to be there or are they leftovers from previous modifications.

They're used in a number of places, but some (most? all?) chipsets do
override the "generic" forms, so depending on which chipset(s) you select in the config, some of these functions may not get used.

Putting in an explicit "generic" AGP backend might solve the problem;
the other solution is to put #if guards around those functions. That strikes me as a bit messy and fragile as any new chipset might need them, and we don't want some over-zealous hacker removing them because they're not used by anything at the moment :o)

Splitting the different chipsets into separate files and putting the
"generic" forms in their own "library" file is probably an option, but it's debatable whether that file is big enough to really be worth it.

You could move the ALi-specific code from agp_lookup_host_bridge to
agp_find_supported_device while you're at it ;o) or I might try to do that in my copious quantities of free time.

Quoted 3 lines

Thanks,

Sean Jones

Signature · 6 lines
/* Bill Crawford, Unix Systems Developer, Ebone (formerly GTS Netcom) */
#include <stddiscl>
const char *addresses[] = {
    "[email protected]", "[email protected]",     // work
    "[email protected]", "[email protected]"                    // home
};