Skip to contentSkip to conversation

sis drm module

PATCH In review Thomas Winischhofer 2 participants 2 messages Dec 27, 2001 – Dec 28, 2001 Kbuild

lore
Share & tools
lore

Thomas Winischhofer

author
#0 lore raw

PATCH 1/1 sis drm module

Hi,

without this patch, only root can execute DRI applications under X. Users can't and just receive a (incorrect) "out of video memory" error, which is basically a "permission denied".

Please apply.

Thomas

Signature · 3 lines
Thomas Winischhofer
Vienna/Austria
mailto:[email protected]              *** http://www.webit.com/tw
usr/src/linux/drivers/char/drm/sis_drv.c renamed from usr/src/linux/drivers/char/drm/sis_drv_old.c +2 -2
@@ -40,8 +40,8 @@
 #define DRIVER_PATCHLEVEL  0
 
 #define DRIVER_IOCTLS \
-        [DRM_IOCTL_NR(SIS_IOCTL_FB_ALLOC)]   = { sis_fb_alloc,	  1, 1 }, \
-        [DRM_IOCTL_NR(SIS_IOCTL_FB_FREE)]    = { sis_fb_free,	  1, 1 }, \
+        [DRM_IOCTL_NR(SIS_IOCTL_FB_ALLOC)]   = { sis_fb_alloc,	  1, 0 }, \
+        [DRM_IOCTL_NR(SIS_IOCTL_FB_FREE)]    = { sis_fb_free,	  1, 0 }, \
         /* AGP Memory Management */					  \
         [DRM_IOCTL_NR(SIS_IOCTL_AGP_INIT)]   = { sisp_agp_init,	  1, 1 }, \
         [DRM_IOCTL_NR(SIS_IOCTL_AGP_ALLOC)]  = { sisp_agp_alloc,  1, 1 }, \
#1 lore raw
Quoted 9 lines · you

Hi,

without this patch, only root can execute DRI applications under X. Users can't and just receive a (incorrect) "out of video memory" error, which is basically a "permission denied".

Please apply.

Thomas

Definitely gets my vote... The patch also resolves a hard xfree86-4.1.0 build error of sis_alloc.c Thank you Thomas, you've helped to make my life a little bit easier! Please, Apply the patch

Jason Lott

Quoted 17 lines

--
Thomas Winischhofer
Vienna/Austria
mailto:[email protected] *** http://www.webit.com/tw--- /usr/src/linux/drivers/char/drm/sis_drv_old.c Thu Dec 27 23:52:11 2001
+++ /usr/src/linux/drivers/char/drm/sis_drv.c Thu Dec 27 23:45:48 2001

usr/src/linux/drivers/char/drm/sis_drv.c renamed from usr/src/linux/drivers/char/drm/sis_drv_old.c +2 -2
@@ -40,8 +40,8 @@
 #define DRIVER_PATCHLEVEL  0
 
 #define DRIVER_IOCTLS \
-        [DRM_IOCTL_NR(SIS_IOCTL_FB_ALLOC)]   = { sis_fb_alloc,   1, 1 }, \
-        [DRM_IOCTL_NR(SIS_IOCTL_FB_FREE)]    = { sis_fb_free,    1, 1 }, \
+        [DRM_IOCTL_NR(SIS_IOCTL_FB_ALLOC)]   = { sis_fb_alloc,   1, 0 }, \
+        [DRM_IOCTL_NR(SIS_IOCTL_FB_FREE)]    = { sis_fb_free,    1, 0 }, \
         /* AGP Memory Management */                                      \
         [DRM_IOCTL_NR(SIS_IOCTL_AGP_INIT)]   = { 
 sisp_agp_init,          1, 1 }, \

         [DRM_IOCTL_NR(SIS_IOCTL_AGP_ALLOC)]  = { sisp_agp_alloc,  1, 1 }, \