aa-150-read_write_tweaks

PATCH Andrew Morton 1 participant 1 message Mar 20, 2002

Subsystems (2)

Memory management Page cache

lore

Share & tools

lore

Andrew Morton

author

2002-03-20 04:04 UTC #0 lore raw

- Don't do flush_page_to_ram() on the page fault-in path. That's handled in mm/memory.c, and filemap.c doesn't need to do it.

- In generic_file_write(), only set the page's Referenced bit once, when the write touches the start of the page. This is a microoptimisation. Seemingly a buggy one too - lseek exists...

=====================================

mm/filemap.c renamed from mm/filemap.c~aa-150-read_write_tweaks +8 -2

@@ -1968,7 +1968,6 @@ success:
 	 * and possibly copy it over to another page..
 	 */
 	mark_page_accessed(page);
-	flush_page_to_ram(page);
 	return page;
 
 no_cached_page:

@@ -3089,8 +3088,15 @@ generic_file_write(struct file *file,con
 		}
 unlock:
 		kunmap(page);
+
+		/*
+		 * Mark the page accessed if we wrote the
+		 * beginning or we just did an lseek.
+		 */
+		if (!offset || !file->f_reada)
+			SetPageReferenced(page);
+
 		/* Mark it unlocked again and drop the page.. */
-		SetPageReferenced(page);
 		UnlockPage(page);
 		page_cache_release(page);