aa-200-active_page_swapout
Subsystems (3)
Last one.
Don't bother checking for active pages in the swapout path.
Not sure about this one. Clearly the page isn't *likely* to be on the active list, because the caller found it on the inactive list. But I don't see any locking which would prevent the page from getting bumped up to the active list in the meanwhile.
Needs more explanation.
=====================================
mm/vmscan.c renamed from mm/vmscan.c~aa-200-active_page_swapout +0 -4
@@ -83,10 +83,6 @@ static inline int try_to_swap_out(structreturn 0 ; } -/* Don't bother unmapping pages that are active */ -if (PageActive (page)) -return 0 ; -/* Don't bother replenishing zones not under pressure.. */ if (!memclass (page_zone (page), classzone))return 0 ;
-
Quoted 4 lines · Andrew Morton
Don't bother checking for active pages in the swapout path.
Not sure about this one. Clearly the page isn't *likely* to be on the active list, because the caller found it on the inactive list.
Mmmm nope.
The caller of swap_out (shrink_caches) may have been scanning the inactive list, but swap_out itself scans the page tables.
This means it can encounter all kinds of pages, active, inactive and even reserved pages.
Quoted 16 lines
mm/vmscan.c renamed from mm/vmscan.c~aa-200-active_page_swapout +0
-6@@ -83,10 +83,6 @@ static inline int try_to_swap_out(structreturn 0 ; } -/* Don't bother unmapping pages that are active */ -if (PageActive (page)) -return 0 ; -/* Don't bother replenishing zones not under pressure.. */ if (!memclass (page_zone (page), classzone))return 0 ; - -
Quoted 5 lines
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Rik
Signature · 3 lines
Bravely reimplemented by the knights who say "NIH". http://www.surriel.com/ http://distro.conectiva.com/
Quoted 8 lines · Rik van Riel
Quoted 4 lines · Andrew Morton
Don't bother checking for active pages in the swapout path.
Not sure about this one. Clearly the page isn't *likely* to be on the active list, because the caller found it on the inactive list.
Quoted 8 lines
Mmmm nope.
The caller of
swap_out(shrink_caches) may have been scanning the inactive list, butswap_outitself scans the page tables.This means it can encounter all kinds of pages, active, inactive and even reserved pages.
good point :)
So what does the patch do?
-