Skip to contentSkip to conversation

Multiple zlib.c's in 2.4.18

DISCUSSION Sverker Wiberg 3 participants 3 messages Apr 12, 2002 – Apr 13, 2002

lore
Share & tools
lore
#0 lore raw

Doing

 $ find . -name 'zlib.c'

on the Linux 2.4.18 source reveals the three zlibs

./fs/jffs2/zlib.c
./drivers/net/zlib.c
./arch/ppc/boot/lib/zlib.c

Further checking reveals that ./arch/ppc/boot/lib/zlib.c is based on zlib-0.95, while the other two are zlib-1.0.4.

Which one should I use? Shouldn't they be merged? And what about the double-free() bug?

/Sverker

#1 lore raw
Quoted 5 lines

Further checking reveals that ./arch/ppc/boot/lib/zlib.c is based on zlib-0.95, while the other two are zlib-1.0.4.

Which one should I use? Shouldn't they be merged? And what about the double-free() bug?

There is progress going on to merge them (see 2.4.19-ac) so hopefully RSN that question won't be worth asking.

#2 lore raw
In reply to Sverker Wiberg
Quoted 8 lines · Alan Cox
Quoted 5 lines

Further checking reveals that ./arch/ppc/boot/lib/zlib.c is based on zlib-0.95, while the other two are zlib-1.0.4.

Which one should I use? Shouldn't they be merged? And what about the double-free() bug?

There is progress going on to merge them (see 2.4.19-ac) so hopefully RSN that question won't be worth asking.

All of them that can be anyhow. I'm hoping no one will touch arch/ppc/boot/lib/zlib.c :)

Signature · 2 lines
Tom Rini (TR1265)
http://gate.crashing.org/~trini/