- "idebus=66" in 2.5.8 results in "ide_setup: idebus=66 -- BAD OPTION"

COMMENTS IDE 2.5 Morten Helgesen 7 participants 11 messages Apr 15, 2002

lore

Share & tools

lore

Morten Helgesen

author

2002-04-15 09:23 UTC #0 lore raw

Hey Martin (and the rest of you)

Been testing 2.5.8 for an hour or so, and noticed the following :

[11:14][root@sexything:/home/admin]$ dmesg | grep idebus
Kernel command line: BOOT_IMAGE=2.5.8-without-TCQ ro root=303 video=matrox:vesa:0x118 idebus=66 profile=2
ide_setup: idebus=66 -- BAD OPTION

With 2.5.8-pre3 :

[11:15][root@sexything:/home/admin]$ cat ./IDEBUS
Kernel command line: BOOT_IMAGE=2.5.8-pre3 ro root=303 video=matrox:vesa:0x118 idebus=66 profile=2
ide_setup: idebus=66

Now, I do not know the reasons for changing the code that handles "idebus=" stuff in ide.c (except from the fact that it now looks cleaner :) - just thought I should let you know. I do not have the time right now to hunt down the bug(?) and cook up a patch, but if you want me to, I`ll do it later today.

One more thing, Martin - I compiled a 2.5.8 with TCQ enabled (yep, I`m aware of the fact that this one is _really_ alpha :), and tested it for, oh ... 10 minutes ... the system gave me all sorts of funny responses - segfaults, "inconsistency in ld.so" and so on ... would you like me to collect 'funnies' and send them to you ? If so, just give me a hint.

== Morten

Signature · 8 lines

"Livet er ikke for nybegynnere" - sitat fra en klok person.

mvh
Morten Helgesen 
UNIX System Administrator & C Developer 
Nextframe AS
[email protected] / 93445641
http://www.nextframe.net

Martin Dalecki

2002-04-15 09:27 UTC #1 lore raw

Quoted 3 lines · Morten Helgesen

Hey Martin (and the rest of you)
Now, I do not know the reasons for changing the code that handles "idebus=" stuff in ide.c (except from the fact

Should be an off by one error there.

Quoted 2 lines

that it now looks cleaner :) - just thought I should let you know. I do not have the time right now to hunt down the bug(?) and cook up a patch, but if you want me to, I`ll do it later today.

I would love if you could have a look at it...

Quoted 1 line

One more thing, Martin - I compiled a 2.5.8 with TCQ enabled (yep, I`m aware of the fact that this one is _really_ alpha :), and tested it for, oh ... 10 minutes ... the system gave me all sorts of funny responses - segfaults, "inconsistency in ld.so" and so on ... would you like me to collect 'funnies' and send them to you ? If so, just give me a hint.

Thats mostly Jens stuff...

Morten Helgesen

author

2002-04-15 09:34 UTC #2 lore raw

In reply to Morten Helgesen

Quoted 7 lines · Martin Dalecki

Quoted 4 lines · Morten Helgesen
Hey Martin (and the rest of you)
Now, I do not know the reasons for changing the code that handles "idebus=" stuff in ide.c (except from the fact
Should be an off by one error there.

yep - that`s what struck me.

Quoted 7 lines

Quoted 5 lines
that it now looks cleaner :) - just thought I should let you know. I do not have the time right now to hunt down
the bug(?) and cook up a patch, but if you want me to, I`ll do it later today.
I would love if you could have a look at it...

sure - I`ll have a look at it in an hour or two.

Quoted 8 lines

Quoted 6 lines
One more thing, Martin - I compiled a 2.5.8 with TCQ enabled (yep, I`m aware of the fact that this one is _really_ alpha :), and tested it for, oh ... 10 minutes ... the system gave me all sorts of funny responses - segfaults, "inconsistency in ld.so" and so on ... would you like me to collect 'funnies' and send them to you ? If so, just give me a hint.
Thats mostly Jens stuff...

ok - Jens ?

I forgot to mention that 2.5.8 _without_ TCQ works like a charm - that`s why I made TCQ my main suspect :)

Quoted 6 lines

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

== Morten

Signature · 8 lines

"Livet er ikke for nybegynnere" - sitat fra en klok person.

mvh
Morten Helgesen 
UNIX System Administrator & C Developer 
Nextframe AS
[email protected] / 93445641
http://www.nextframe.net

Jens Axboe

2002-04-15 09:40 UTC #3 lore raw

In reply to Morten Helgesen

Quoted 9 lines · Morten Helgesen

Quoted 7 lines
Quoted 5 lines
One more thing, Martin - I compiled a 2.5.8 with TCQ enabled (yep, I`m aware of the fact that this one is _really_ alpha :), and tested it for, oh ... 10 minutes ... the system gave me all sorts of funny responses - segfaults, "inconsistency in ld.so" and so on ... would you like me to collect 'funnies' and send them to you ? If so, just give me a hint.
Thats mostly Jens stuff...
ok - Jens ?

Would love to see it! Also send me the ide bootup messages. Note that 2.5.8 has at least on irq race with tcq dma that I've fixed, but I'd like to see the setup anyways. Did you get any dmesg errors?

Signature · 1 line

Jens Axboe

Morten Helgesen

author

2002-04-15 12:15 UTC #4 lore raw

In reply to Morten Helgesen

Hey again, Martin :)

What do you think about the following :

drivers/ide/ide.c Mon Apr 15 14:09:18 2002 renamed from drivers/ide/ide.c Sun Apr 14 21:18:52 2002 +1 -1

@@ -3120,7 +3120,7 @@
        /*
         * Look for bus speed option:  "idebus="
         */
-       if (strncmp(s, "idebus", 6)) {
+       if (strncmp(s, "idebus", 6) == 0) {
                if (match_parm(&s[6], NULL, vals, 1) != 1)
                        goto bad_option;
                if (vals[0] >= 20 && vals[0] <= 66) {

gives :

Kernel command line: BOOT_IMAGE=2.5.8-without-TCQ ro root=303 video=matrox:vesa:0x118 idebus=66 profile=2
ide_setup: idebus=66
ide: system bus speed 66MHz

works like a charm :)

== Morten

Quoted 21 lines · Martin Dalecki

Quoted 4 lines · Morten Helgesen
Hey Martin (and the rest of you)
Now, I do not know the reasons for changing the code that handles "idebus=" stuff in ide.c (except from the fact
Should be an off by one error there.
Quoted 4 lines
that it now looks cleaner :) - just thought I should let you know. I do not have the time right now to hunt down
the bug(?) and cook up a patch, but if you want me to, I`ll do it later today.
I would love if you could have a look at it...
Quoted 5 lines
One more thing, Martin - I compiled a 2.5.8 with TCQ enabled (yep, I`m aware of the fact that this one is _really_ alpha :), and tested it for, oh ... 10 minutes ... the system gave me all sorts of funny responses - segfaults, "inconsistency in ld.so" and so on ... would you like me to collect 'funnies' and send them to you ? If so, just give me a hint.

Quoted 7 lines

Thats mostly Jens stuff...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

== Morten

Signature · 8 lines

"Livet er ikke for nybegynnere" - sitat fra en klok person.

mvh
Morten Helgesen 
UNIX System Administrator & C Developer 
Nextframe AS
[email protected] / 93445641
http://www.nextframe.net

Meelis Roos

2002-04-15 17:20 UTC #5 lore raw

MH> Kernel command line: BOOT_IMAGE=2.5.8-without-TCQ ro root=303 video=matrox:vesa:0x118 idebus=66 profile=2 MH> ide_setup: idebus=66
MH> ide: system bus speed 66MHz

MH> works like a charm :)

Do you really have an IDE controller that does 66 MHz PCI? What kind on IDE controller is this?

Signature · 1 line

Meelis Roos ([email protected])

Maxwell Spangler

2002-04-15 22:05 UTC #6 lore raw

Quoted 8 lines · Meelis Roos

MH> Kernel command line: BOOT_IMAGE=2.5.8-without-TCQ ro root=303 video=matrox:vesa:0x118 idebus=66 profile=2 MH> ide_setup: idebus=66
MH> ide: system bus speed 66MHz
MH> works like a charm :)
Do you really have an IDE controller that does 66 MHz PCI? What kind on IDE controller is this?

I have a Promise Ultra133TX2 card on my shelf that is 32-bit PCI with 66Mhz operation.

I don't know to what extent it is supported yet.. Andre?
-- ----------------------------------------------------------------------------
Maxwell Spangler Save Futurama!
Program Writer Sign the petition!
Greenbelt, Maryland, U.S.A. http://www.gotfuturama.com/
Washington D.C. Metropolitan Area

Andre Hedrick

2002-04-15 22:55 UTC #7 lore raw

Do not know what is left of the kernel base in 2.5 as I am out of the development tree. Somewhat offically kicked out of Linux. After 2.4 pass on so will I.

Cheers,

Andre Hedrick
LAD Storage Consulting Group

Quoted 27 lines · Maxwell Spangler

Quoted 8 lines · Meelis Roos
MH> Kernel command line: BOOT_IMAGE=2.5.8-without-TCQ ro root=303 video=matrox:vesa:0x118 idebus=66 profile=2 MH> ide_setup: idebus=66
MH> ide: system bus speed 66MHz
MH> works like a charm :)
Do you really have an IDE controller that does 66 MHz PCI? What kind on IDE controller is this?
I have a Promise Ultra133TX2 card on my shelf that is 32-bit PCI with 66Mhz operation.
I don't know to what extent it is supported yet.. Andre?
-- ----------------------------------------------------------------------------
Maxwell Spangler Save Futurama!
Program Writer Sign the petition!
Greenbelt, Maryland, U.S.A. http://www.gotfuturama.com/
Washington D.C. Metropolitan Area
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Maxwell Spangler

2002-04-15 23:44 UTC #8 lore raw

Quoted 4 lines · Andre Hedrick

Do not know what is left of the kernel base in 2.5 as I am out of the development tree. Somewhat offically kicked out of Linux. After 2.4 pass on so will I.

I'm interested in production systems, and that means staying with 2.4 for a LONG time from now. So your code for 2.4.x is very relevant to me and that's why I was asking..

Is the Promise Ultra133TX2 supported with 2.4.18, or do I need to patch in your major ATA upgrade? (Which I assume is still a patch and not included in the mainstream kernel?)

Thanks!

-- ----------------------------------------------------------------------------
Maxwell Spangler Save Futurama!
Program Writer Sign the petition!
Greenbelt, Maryland, U.S.A. http://www.gotfuturama.com/
Washington D.C. Metropolitan Area

Vojtech Pavlik

2002-04-15 22:39 UTC #9 lore raw

In reply to Meelis Roos

Quoted 8 lines · Maxwell Spangler

Quoted 6 lines · Meelis Roos
MH> Kernel command line: BOOT_IMAGE=2.5.8-without-TCQ ro root=303 video=matrox:vesa:0x118 idebus=66 profile=2 MH> ide_setup: idebus=66
MH> ide: system bus speed 66MHz
MH> works like a charm :)

Quoted 7 lines

Quoted 2 lines
Do you really have an IDE controller that does 66 MHz PCI? What kind on IDE controller is this?
I have a Promise Ultra133TX2 card on my shelf that is 32-bit PCI with 66Mhz operation.
I don't know to what extent it is supported yet.. Andre?

The promise driver ignores the idebus= value anyway. :) And for others 66 is usually an invalid setting.

Signature · 2 lines

Vojtech Pavlik
SuSE Labs

Martin Dalecki

2002-04-15 12:26 UTC #10 lore raw

In reply to Morten Helgesen

Quoted 3 lines · Morten Helgesen

Hey again, Martin :)
What do you think about the following :

What I think? I think it's abviously right... Thank you very much and sorry for the inconvenience!

And judging from the other typos fixed in patch number 34 I think that I should stick to my "principles" and don't write code past 02:00 o'clock ... :-).

Quoted 20 lines

drivers/ide/ide.c Mon Apr 15 14:09:18 2002 renamed from drivers/ide/ide.c Sun Apr 14 21:18:52 2002 +1 -1
@@ -3120,7 +3120,7 @@
        /*
         * Look for bus speed option:  "idebus="
         */
-       if (strncmp(s, "idebus", 6)) {
+       if (strncmp(s, "idebus", 6) == 0) {
                if (match_parm(&s[6], NULL, vals, 1) != 1)
                        goto bad_option;
                if (vals[0] >= 20 && vals[0] <= 66) {
gives :
Kernel command line: BOOT_IMAGE=2.5.8-without-TCQ ro root=303 video=matrox:vesa:0x118 idebus=66 profile=2
ide_setup: idebus=66
ide: system bus speed 66MHz
works like a charm :)