Skip to contentSkip to conversation

2.5.13 IDE PIO mode Fix

PATCH In review Osamu Tomita 2 participants 2 messages May 3, 2002 – May 5, 2002

lore
Share & tools
lore

Osamu Tomita

author
#0 lore raw

PATCH 1/1 2.5.13 IDE PIO mode Fix

I found this bug in 2.5.10 first. And caused ext2 FS corruption. We are porting Linux to PC-9801 architecture (made by NEC Japan). It has PIO ONLY IDE I/F. So please check PIO mode too.
# Our porting status - 2.2.x/2.4.x done and updating. 2.5.x partial.

drivers/ide/ide-taskfile.c Fri Apr 26 15:44:42 2002 renamed from drivers/ide/ide-taskfile.c Wed Apr 24 16:15:19 2002 +1 -1
diff -urN linux-2.5.10/drivers/ide/ide-taskfile.c linux/drivers/ide/ide-taskfile.c
@@ -202,7 +202,7 @@
                        ata_write_slow(drive, buffer, wcount);
                else
 #endif
-                       ata_write_16(drive, buffer, wcount<<1);
+                       ata_write_16(drive, buffer, wcount);
        }
 }
#1 lore raw

Uz.ytkownik Osamu Tomita napisa?:

Quoted 3 lines

I found this bug in 2.5.10 first. And caused ext2 FS corruption. We are porting Linux to PC-9801 architecture (made by NEC Japan). It has PIO ONLY IDE I/F. So please check PIO mode too.

Hey I can't do everything. And I know that people like you will check it anyway :-)... But seriously - Thank you very much for the plague and indeed 16 bit transfers are something I see makes sense for embedded platforms.

Quoted 13 lines

# Our porting status - 2.2.x/2.4.x done and updating. 2.5.x partial.

diff -urN linux-2.5.10/drivers/ide/ide-taskfile.c linux/drivers/ide/ide-taskfile.c

drivers/ide/ide-taskfile.c Fri Apr 26 15:44:42 2002 renamed from drivers/ide/ide-taskfile.c Wed Apr 24 16:15:19 2002 +1 -1
@@ -202,7 +202,7 @@
                        ata_write_slow(drive, buffer, wcount);
                else
 #endif
-                       ata_write_16(drive, buffer, wcount<<1);
+                       ata_write_16(drive, buffer, wcount);
        }
 }