Skip to contentSkip to conversation

warning fix for ide.h

PATCH In review Art Haas 2 participants 2 messages Jul 27, 2002 – Jul 29, 2002

lore
Share & tools
lore

Art Haas

author
#0 lore raw

PATCH 1/1 warning fix for ide.h

Hi.

I saw this when building 2.5.29 ...

make[2]: Entering directory `/mnt/src/linux-2.5.29/drivers/ide' gcc -Wp,-MD,./.ide-cd.o.d -D__KERNEL__ -I/mnt/src/linux-2.5.29/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i586 -nostdinc -iwithprefix include -DMODULE
-DKBUILD_BASENAME=ide_cd -c -o ide-cd.o ide-cd.c
ide-cd.c: In function `ide_cdrom_do_request':
ide-cd.c:1623: warning: implicit declaration of function `ide_stall_queue'

Adding a prototype to ide.h removes the warning.

include/linux/ide.h renamed from include/linux/ide.h.old +1 -0
@@ -656,6 +656,7 @@
 extern int ide_spin_wait_hwgroup(struct ata_device *);
 extern void ide_timer_expiry(unsigned long data);
 extern void ata_irq_request(int irq, void *data, struct pt_regs *regs);
+extern void ide_stall_queue(struct ata_device * drive, unsigned long timeout);
 extern void do_ide_request(request_queue_t * q);
 extern void ide_init_subdrivers(void);
 
Signature · 3 lines
They that can give up essential liberty to obtain a little temporary
safety deserve neither liberty nor safety.
 -- Benjamin Franklin, Historical Review of Pennsylvania, 1759
#1 lore raw
Quoted 13 lines · Art Haas

Hi.

I saw this when building 2.5.29 ...

make[2]: Entering directory `/mnt/src/linux-2.5.29/drivers/ide' gcc -Wp,-MD,./.ide-cd.o.d -D__KERNEL__ -I/mnt/src/linux-2.5.29/include

(quoted diff) +0 -4
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=i586 -nostdinc -iwithprefix include -DMODULE
-DKBUILD_BASENAME=ide_cd   -c -o ide-cd.o ide-cd.c

ide-cd.c: In function `ide_cdrom_do_request':
ide-cd.c:1623: warning: implicit declaration of function `ide_stall_queue'

Quoted 1 line

Adding a prototype to ide.h removes the warning.

Please don't bother - this function is subject to go.