113: plugin/keyboard vs. plugin/kbd_unicode ?
Hello.
Quoted 2 lines · Per Jessen
In plugin/kbd_unicode, "no keyboard" is explicitly recognised, but doesn't seem to default to reading stdin ?
Looking in keyb_none.c it seems that "no keyboard" does absolutely nothing - just a dummy client. Raw keyboard client seems to be using stdin (see raw_keyboard_init() ).
Quoted 1 line
Which part of the keyboard code is actually being used for 113 ?
non-unicode one.
Quoted 2 lines
Eric Biedermans
kbd_unicodelooks somewhat cleaner, but it is not the default that is "shipped"?
It is default since 1.1.3.2 so upgrade if you are going to do some hacking.
As of your other message: lredir still works OK for me (1.1.3.2)
Quoted 8 lines · Stas Sergeev
Quoted 2 lines · Per Jessen
In plugin/kbd_unicode, "no keyboard" is explicitly recognised, but doesn't seem to default to reading stdin ?
Looking in
keyb_none.cit seems that "no keyboard" does absolutely nothing - just a dummy client. Raw keyboard client seems to be using stdin (seeraw_keyboard_init()).
It uses a special mode of stdin, raw mode, which is only available at the console.
The slang keyboard should work with stdin eventually -- it should check for a tty at some places where it does not now. Feel free to look into it ;)
Bart
Quoted 7 lines · Bart Oldeman
Quoted 5 lines · Stas Sergeev
Quoted 3 lines · Per Jessen
In plugin/kbd_unicode, "no keyboard" is explicitly recognised, but doesn't seem to default to reading stdin ?
Quoted 7 lines
It uses a special mode of stdin, raw mode, which is only available at the console.
The slang keyboard should work with stdin eventually -- it should check for a tty at some places where it does not now. Feel free to look into it ;)
I did spend some time looking at slang stuff - decided I would rather look at Erics kbd_unicode stuff :-)
Seriously - in Eric's code, he has X, raw, slang and none keyboard modes. It seems to me that slang isn't the right place to add stdin support - wouldn't it be better to add a 5th keyboard mode "piped" or "stdin" ?
/Per
Quoted 4 lines · Stas Sergeev
Hello.
Per Jessen wrote:
Quoted 8 lines
Quoted 2 lines
In plugin/kbd_unicode, "no keyboard" is explicitly recognised, but doesn't seem to default to reading stdin ?
Looking in
keyb_none.cit seems that "no keyboard" does absolutely nothing - just a dummy client. Raw keyboard client seems to be using stdin (seeraw_keyboard_init()).
Yeah, I saw that too - but when the actual keyboard client is selected, it seems that raw is only picked if some option for running as root is also picked ? (I'm away from my office, can't check the code)
Quoted 6 lines
Quoted 2 lines
Eric Biedermans
kbd_unicodelooks somewhat cleaner, but it is not the default that is "shipped"?It is default since 1.1.3.2 so upgrade if you are going to do some hacking.
Thanks - that's exactly what I was looking for. I already went with the kbd-unicode stuff - works fine.
Quoted 2 lines
As of your other message: lredir still works OK for me (1.1.3.2)
OK, guess I'll have to do some more checking.
thanks,
Per