2.4.20 ARCH=i386 create dmi_scan.h and move decl
PATCH 1/1 2.4.20 ARCH=i386 create dmi_scan.h and move decl
fyi
-------- Original Message --------
Subject: Re: [PATCH]2.4.20 ARCH=i386 create dmi_scan.h and move decl fromdmi_scan.c
Date: 13 Aug 2002 13:13:04 +0100
From: Alan Cox <[email protected]>
To: Albert Cranford <[email protected]>,Linus Torvalds<[email protected]>
CC: Marcelo Tosatti <[email protected]>,Linux Kernel List<[email protected]>
References: <[email protected]>
Review
Quoted 3 lines · Albert Cranford
(quoted diff) +1
-2- -static char *dmi_ident[DMI_STRING_MAX]; +char *dmi_ident[DMI_STRING_MAX];
Be very careful with this change btw. The dmi_ident strings are unmapped at the point dmi_table() returns. That means you can only use them in the decode callback, and so it seems odd to export them. It certainly wants clear documentation if you are doing it that way.
What you probably should do is create some flag bits for i2c/smbus and set those then export the flag data (we do the same for APM), rather than export them as globals
PATCH 1/1 2.4.20 ARCH=i386 create dmi_scan.h and move decl
well, Alan originally said we could do it either way but now he says we can only export the flags rather than export dmi_ident.
Albert, I'll come up with a patch to dmi_scan and send it to you to look at
and send on.
mds
Quoted 23 lines · Albert Cranford
fyi
-------- Original Message --------
Subject: Re: [PATCH]2.4.20 ARCH=i386 createdmi_scan.hand move declfromdmi_scan.c
Date: 13 Aug 2002 13:13:04 +0100
From: Alan Cox <[email protected]>
To: Albert Cranford <[email protected]>,Linus Torvalds<[email protected]>
CC: Marcelo Tosatti <[email protected]>,Linux Kernel List<[email protected]>
References: <[email protected]>Review
Quoted 3 lines · Albert Cranford
(quoted diff) +1
-2- -static char *dmi_ident[DMI_STRING_MAX]; +char *dmi_ident[DMI_STRING_MAX];Be very careful with this change btw. The
dmi_identstrings are unmapped at the pointdmi_table()returns. That means you can only use them in the decode callback, and so it seems odd to export them. It certainly wants clear documentation if you are doing it that way.What you probably should do is create some flag bits for i2c/smbus and set those then export the flag data (we do the same for APM), rather than export them as globals