Skip to contentSkip to conversation

of dentries and inodes

DISCUSSION Eli Carter 2 participants 2 messages Aug 14, 2002

lore
Share & tools
lore

Eli Carter

author
#0 lore raw

All,

Ok, I'm puzzled... I have not yet found an answer from groups.google or my oreilly tomes. :/

(I'm looking at a 2.2 kernel, but I doubt this has changed.) In ext2, as well as many other fs's, there appears a line much like this in their 'struct file_system_type.read_super()' function:

sb->s_root = d_alloc_root(iget(sb, EXT2_ROOT_INO), NULL);

Now, I was under the impression that for each iget(), you need to have an iput() when you're done with the inode... which in this case would mean an iput() in 'struct super_operations.put_super()'... but I don't see one there.

So I would expect the root inode might hang around in the filesystem cache(s) after a umount. But I would expect that to cause filesystem corruption on a regular basis. ('mount, umount, mkfs' for example, would yield an inconsistancy between disk and filesystem cache.)

I'm missing something, or misunderstand something, or both... can anyone point me in the right direction?

TIA,

Eli
--------------------. "If it ain't broke now,
Eli Carter \ it will be soon." -- crypto-gram
eli.carter(a)inet.com `-------------------------------------------------

#1 lore raw
Quoted 10 lines · Eli Carter

(I'm looking at a 2.2 kernel, but I doubt this has changed.) In ext2, as well as many other fs's, there appears a line much like this in their 'struct file_system_type.read_super()' function:

sb->s_root = d_alloc_root(iget(sb, EXT2_ROOT_INO), NULL);

Now, I was under the impression that for each iget(), you need to have an iput() when you're done with the inode... which in this case would mean an iput() in 'struct super_operations.put_super()'... but I don't see one there.

The dput(root) is done in fs/super.c (kill_super in 2.4).

Cheers, Andreas
--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/