ide-floppy & devfs - /dev entry not created if drive is empty

DISCUSSION Stanislav Brabec 3 participants 7 messages Aug 18, 2002 – Aug 20, 2002

lore

Share & tools

lore

Stanislav Brabec

author

2002-08-18 18:56 UTC #0 lore raw

Hallo Paul Bristow,

I have tested ide-floppy on my Linux 2.4.19 with ATAPI ZIP 100. I am using devfs.

I found following problem:

If module ide-floppy is loaded and no disc is present in the drive, /dev/ide/host0/bus1/target1/lun0/disc entry is not created. Later inserted media cannot be checked in any way, because no /dev entry exists.

Older kernels have also this behavior.

Fix: Create .../disc entry in all cases, even if no disc is present.

Signature · 2 lines

Stanislav Brabec
http://www.penguin.cz/~utx

Kevin P. Fleming

2002-08-20 00:00 UTC #1 lore raw

There are patches at http://members.cox.net/kpfleming/ide-floppy to resolve this.

Quoted 16 lines · Stanislav Brabec

Hallo Paul Bristow,
I have tested ide-floppy on my Linux 2.4.19 with ATAPI ZIP 100. I am using devfs.
I found following problem:
If module ide-floppy is loaded and no disc is present in the drive, /dev/ide/host0/bus1/target1/lun0/disc entry is not created. Later inserted media cannot be checked in any way, because no /dev entry exists.
Older kernels have also this behavior.
Fix: Create .../disc entry in all cases, even if no disc is present.

Andre Hedrick

2002-08-20 00:41 UTC #2 lore raw

Patch is welcome here.

Drop it on AC and myself please.

Quoted 18 lines · Kevin P. Fleming

There are patches at http://members.cox.net/kpfleming/ide-floppy to resolve this.
Quoted 14 lines · Stanislav Brabec
Hallo Paul Bristow,
I have tested ide-floppy on my Linux 2.4.19 with ATAPI ZIP 100. I am using devfs.
I found following problem:
If module ide-floppy is loaded and no disc is present in the drive, /dev/ide/host0/bus1/target1/lun0/disc entry is not created. Later inserted media cannot be checked in any way, because no /dev entry exists.
Older kernels have also this behavior.

Quoted 9 lines

Quoted 2 lines
Fix: Create .../disc entry in all cases, even if no disc is present.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Andre Hedrick
LAD Storage Consulting Group

Kevin P. Fleming

2002-08-20 01:08 UTC #3 lore raw

I'll let Paul handle this, since he is the ide-floppy maintainer and has some other changes he wants to make. If you do not get anything from him in a week or so, please let me know and I'll updates the patches to the latest -ac kernel and send them.

Oh, there is one non-ide-floppy patch, this cleans up a small part of ide-probe and ensures that ide-floppy devices are marked as removable devices. Last kernel I applied it to was 2.4.20-pre2-ac1, it may have problems with the newer ones if you've worked on ide-probe.

drivers/ide/ide-probe.c +28 ~~-19~~

diff -X dontdiff -urN linux/drivers/ide/ide-probe.c linux-probe/drivers/ide/ide-probe.c
@@ -130,31 +130,40 @@
 			goto err_misc;
 		}
 #endif /* CONFIG_BLK_DEV_PDC4030 */
+		/*
+		 * Handle drive type overrides for "unusual" devices
+		 */
 		switch (type) {
-			case ide_floppy:
-				if (!strstr(id->model, "CD-ROM")) {
-					if (!strstr(id->model, "oppy") &&
-					    !strstr(id->model, "poyp") &&
-					    !strstr(id->model, "ZIP"))
-						printk("cdrom or floppy?, assuming ");
-					if (drive->media != ide_cdrom) {
-						printk ("FLOPPY");
-						break;
-					}
-				}
+		case ide_floppy:
+			if (strstr(id->model, "CD-ROM")) {
+				type = ide_cdrom;
+				break;
+			}
+			if (!strstr(id->model, "oppy") &&
+			    !strstr(id->model, "poyp") &&
+			    !strstr(id->model, "ZIP"))
+				printk("cdrom or floppy?, assuming ");
+			if (drive->media == ide_cdrom)
 				type = ide_cdrom;	/* Early cdrom models used zero */
-			case ide_cdrom:
-				drive->removable = 1;
+			break;
 #ifdef CONFIG_PPC
+		case ide_cdrom:
 				/* kludge for Apple PowerBook internal zip */
-				if (!strstr(id->model, "CD-ROM") &&
-				    strstr(id->model, "ZIP")) {
-					printk ("FLOPPY");
-					type = ide_floppy;
-					break;
-				}
+			if (!strstr(id->model, "CD-ROM") &&
+			    strstr(id->model, "ZIP")) {
+				type = ide_floppy;
+				break;
+			}
 #endif
+		}
+		switch (type) {
+ 			case ide_floppy:
+ 				printk ("FLOPPY");
+ 				drive->removable = 1;
+ 				break;
+ 			case ide_cdrom:
 				printk ("CD/DVD-ROM");
+ 				drive->removable = 1;
 				break;
 			case ide_tape:
 				printk ("TAPE");

Quoted 39 lines · Andre Hedrick

Patch is welcome here.
Drop it on AC and myself please.
Quoted 18 lines · Kevin P. Fleming
There are patches at http://members.cox.net/kpfleming/ide-floppy to resolve this.
Quoted 14 lines · Stanislav Brabec
Hallo Paul Bristow,
I have tested ide-floppy on my Linux 2.4.19 with ATAPI ZIP 100. I am using devfs.
I found following problem:
If module ide-floppy is loaded and no disc is present in the drive, /dev/ide/host0/bus1/target1/lun0/disc entry is not created. Later inserted media cannot be checked in any way, because no /dev entry exists.
Older kernels have also this behavior.
Quoted 9 lines
Quoted 2 lines
Fix: Create .../disc entry in all cases, even if no disc is present.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Andre Hedrick
LAD Storage Consulting Group

Andre Hedrick

2002-08-20 01:16 UTC #4 lore raw

Thanks Kevin!

Regardless we do it now, I have been held off for to long to clean house.

AC and I are on a major role. AC is putting the final touchs on the my original modular chipset solution. He is doing the kernel correctness while I keep the within the limits of the hardware. The converse is as I go broad in design and intentionally bloat code to show common calls, AC is able to finish the slice and final code reductions as togather we purge the history of bloating. AC gets the reason for my bloat direction and on occassion I beat him to the punch on the net bloat reduction solution.

Cheers,

Andre Hedrick
LAD Storage Consulting Group

Quoted 118 lines · Kevin P. Fleming

I'll let Paul handle this, since he is the ide-floppy maintainer and has some other changes he wants to make. If you do not get anything from him in a week or so, please let me know and I'll updates the patches to the latest -ac kernel and send them.
Oh, there is one non-ide-floppy patch, this cleans up a small part of ide-probe and ensures that ide-floppy devices are marked as removable devices. Last kernel I applied it to was 2.4.20-pre2-ac1, it may have problems with the newer ones if you've worked on ide-probe.
diff -X dontdiff -urN linux/drivers/ide/ide-probe.c linux-probe/drivers/ide/ide-probe.c
drivers/ide/ide-probe.c +28 ~~-19~~
@@ -130,31 +130,40 @@
  			goto err_misc;
  		}
  #endif /* CONFIG_BLK_DEV_PDC4030 */
+		/*
+		 * Handle drive type overrides for "unusual" devices
+		 */
  		switch (type) {
-			case ide_floppy:
-				if (!strstr(id->model, "CD-ROM")) {
-					if (!strstr(id->model, "oppy") &&
-					    !strstr(id->model, "poyp") &&
-					    !strstr(id->model, "ZIP"))
-						printk("cdrom or floppy?, assuming ");
-					if (drive->media != ide_cdrom) {
-						printk ("FLOPPY");
-						break;
-					}
-				}
+		case ide_floppy:
+			if (strstr(id->model, "CD-ROM")) {
+				type = ide_cdrom;
+				break;
+			}
+			if (!strstr(id->model, "oppy") &&
+			    !strstr(id->model, "poyp") &&
+			    !strstr(id->model, "ZIP"))
+				printk("cdrom or floppy?, assuming ");
+			if (drive->media == ide_cdrom)
  				type = ide_cdrom;	/* Early cdrom models used zero */
-			case ide_cdrom:
-				drive->removable = 1;
+			break;
  #ifdef CONFIG_PPC
+		case ide_cdrom:
  				/* kludge for Apple PowerBook internal zip */
-				if (!strstr(id->model, "CD-ROM") &&
-				    strstr(id->model, "ZIP")) {
-					printk ("FLOPPY");
-					type = ide_floppy;
-					break;
-				}
+			if (!strstr(id->model, "CD-ROM") &&
+			    strstr(id->model, "ZIP")) {
+				type = ide_floppy;
+				break;
+			}
  #endif
+		}
+		switch (type) {
+ 			case ide_floppy:
+ 				printk ("FLOPPY");
+ 				drive->removable = 1;
+ 				break;
+ 			case ide_cdrom:
  				printk ("CD/DVD-ROM");
+ 				drive->removable = 1;
  				break;
  			case ide_tape:
  				printk ("TAPE");
Quoted 40 lines · Andre Hedrick
Patch is welcome here.
Drop it on AC and myself please.
Quoted 19 lines · Kevin P. Fleming
There are patches at http://members.cox.net/kpfleming/ide-floppy to resolve this.
Quoted 14 lines · Stanislav Brabec
Hallo Paul Bristow,
I have tested ide-floppy on my Linux 2.4.19 with ATAPI ZIP 100. I am using devfs.
I found following problem:
If module ide-floppy is loaded and no disc is present in the drive, /dev/ide/host0/bus1/target1/lun0/disc entry is not created. Later inserted media cannot be checked in any way, because no /dev entry exists.
Older kernels have also this behavior.
Quoted 9 lines
Quoted 2 lines
Fix: Create .../disc entry in all cases, even if no disc is present.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Andre Hedrick
LAD Storage Consulting Group

Stanislav Brabec

author

2002-08-20 16:52 UTC #5 lore raw

In reply to Kevin P. Fleming

Quoted 5 lines · Stanislav Brabec

If module ide-floppy is loaded and no disc is present in the drive, /dev/ide/host0/bus1/target1/lun0/disc entry is not created. Later inserted media cannot be checked in any way, because no /dev entry exists.

Quoted 2 lines · Kevin P. Fleming

diff -X dontdiff -urN linux/drivers/ide/ide-probe.c linux-probe/drivers/ide/ide-probe.c

Does anybody know, whether this problem was present on LS-120/240, IOMEGA PocketZip and JAZ devices and is fixed now?

Signature · 2 lines

Stanislav Brabec
http://www.penguin.cz/~utx

Kevin P. Fleming

2002-08-20 16:58 UTC #6 lore raw

This problem is present on all devices supported by the ide-floppy driver. It won't be fixed until the ide-probe patch makes it into the official kernel. At that point the /dev/discs/... entry for the drive will appear at boot time even without media present in the drive.

However, without my other media change handling patches, the partition entries inside the /dev/discs/... directory for the floppy drive will not stay in sync terribly well when you make media changes.

Quoted 17 lines · Stanislav Brabec

Quoted 5 lines · Stanislav Brabec
If module ide-floppy is loaded and no disc is present in the drive, /dev/ide/host0/bus1/target1/lun0/disc entry is not created. Later inserted media cannot be checked in any way, because no /dev entry exists.
Quoted 2 lines · Kevin P. Fleming
diff -X dontdiff -urN linux/drivers/ide/ide-probe.c linux-probe/drivers/ide/ide-probe.c
Does anybody know, whether this problem was present on LS-120/240, IOMEGA PocketZip and JAZ devices and is fixed now?