Skip to contentSkip to conversation

2.5.38 i2c cleanup using module_init/exit

PATCH New Albert Cranford 3 participants 3 messages May 19, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 2.5.38 i2c cleanup using module_init/exit

No guys. Not acceptable. I don't need handling. Jeff please contact someone at i2c/lm_sensors group if you want to participate is the project.
http://secure.netroedge.com/~lm78/

Albert

Quoted 15 lines · Jeff Garzik
Quoted 6 lines · Linus Torvalds
Quoted 1 line · Jeff Garzik

this patch looks ok to me

Jeff, would you mind handling i2c as well entirely?

Sure, I can do patch penguin-ing for Albert...

Albert, I will apply the 1 out of 3 patches that was ok... Please fix and resend the other two.

Jeff

Signature · 2 lines
Albert Cranford Deerfield Beach FL USA
[email protected]
#1 lore raw

PATCH 1/1 2.5.38 i2c cleanup using module_init/exit

Quoted 1 line · Albert Cranford

No guys. Not acceptable. I don't need handling.

I am not going to be maintainer, all Linus means is that I will review your patches and send them to him. I already do this for IrDA. This lightens Linus's load and gets your patches applied faster.

And judging from the patches you accept and try to pass to Linus, your patches clearly need additional review. What's this, the third revision of them?

Jeff

#2 lore raw

PATCH 1/1 2.5.38 i2c cleanup using module_init/exit

In reply to Albert Cranford
Quoted 2 lines · Albert Cranford

No guys. Not acceptable. I don't need handling.

It's not about handling.

Jeff (like me) doesn't have the time to check the i2c CVS tree etc, and having somebody (you) do that is invaluable.

And I'm in the situation that I spend almost all my time already just merging stuff (check out the actual checkins I've done in the BK tree that aren't just merges, and you'll see that most of them are pretty trivial), and Jeff has been doing the "driver merges" into BK tree's, which makes it simpler for me since I know he actually does look at the patches, and I already merge with his BK trees anyway.

This is why I like multi-level setups. Not because Jeff is "handling" you, but because it means that I have to keep track of fewer things. I'm basically lazy.

I have this theory that people can know about 5-10 people well, and after that they have to spend effort on it. So instead of me merging from 50 people, I'd rather merge from 7, and those 7 can merge from another 7, etc. Leaving everybody comfortable with the load, instead of people being pissed off at me for not merging their patches (which has certainly been the case at times ;)

(I also have ulterior motives, which is to make it easier for me to take a week off every once in a while - just because when there are five or so people who end up doing the tracking of patches _anyway_. I'm planning on taking a few weeks off in Australia in January or something ;).

Linus