Skip to contentSkip to conversation

force_sig_info()

UPATCH Oleg Nesterov 1 participant 2 messages Sep 29, 2002

lore
Share & tools
lore
#0 lore raw

Hello.

This is my third attempt:

Quoted 9 lines · Oleg Nesterov

2.5.34 introduced this change in force_sig_info()

(quoted diff) +1 -1
-	return send_sig_info(sig, info, t);
+	return send_sig_info(sig, (void *)1, t);

I beleive, it is wrong, info can carry useful information from do_page_fault, traps. And this (info *)1 does not prevent send_signal() from allocation of siginfo struct. Ingo, could you please clarify?

Call me stupid, but i still believe it is bug.

kernel/signal.c renamed from kernel/signal.c~ +1 -1
@@ -781,7 +781,7 @@
 	recalc_sigpending_tsk(t);
 	spin_unlock_irqrestore(&t->sigmask_lock, flags);
 
-	return send_sig_info(sig, (void *)1, t);
+	return send_sig_info(sig, info, t);
 }
 
 static int

Oleg.

#1 lore raw

Hello.

Just browsed marc.theaimsgroup.com, it is fixed already. Sorry for noise.

Oleg.