Skip to contentSkip to conversation

CVS: alsa-kernel/usb usbaudio.c,1.12,1.13 ...

alsa-cvslog Clemens Ladisch 2 participants 2 messages Oct 4, 2002 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 11 lines · Jaroslav Kysela

Modified Files:
usbaudio.c usbmidi.c usbmixer.c
Log Message:
Fixes for 2.5 USB core

(...)

(quoted diff) +3 -0
+#ifndef OLD_USB
+	return 0;
+#else

Review

Quoted 10 lines
(quoted diff) +4 -0
 	return chip;
+#endif
 
 
(...)
 
 
+#ifndef OLD_USB
+	void *ptr = dev_get_drvdata(&intf->dev);
+#endif

IMHO a call do dev_set_drvdata(dev, chip) is missing.

Regards
Clemens

-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

#2 lore raw

At Fri, 04 Oct 2002 09:49:01 +0200,

Quoted 21 lines · Clemens Ladisch
Quoted 17 lines · Jaroslav Kysela

Modified Files:
usbaudio.c usbmidi.c usbmixer.c
Log Message:
Fixes for 2.5 USB core

(...)

(quoted diff) +4 -0
+#ifndef OLD_USB
+	return 0;
+#else
 	return chip;
+#endif
 
 
(...)
Quoted 6 lines

Review

Quoted 3 lines
(quoted diff) +3 -0
+#ifndef OLD_USB
+	void *ptr = dev_get_drvdata(&intf->dev);
+#endif

IMHO a call do dev_set_drvdata(dev, chip) is missing.

fixed now.

Takashi

-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf