Skip to contentSkip to conversation

CVS: alsa-kernel/core pcm_lib.c,1.20,1.21

alsa-cvslog Abramo Bagnara 2 participants 2 messages Oct 30, 2002 – Oct 31, 2002 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 18 lines · Takashi Iwai

Update of /cvsroot/alsa/alsa-kernel/core
In directory usw-pr-cvs1:/tmp/cvs-serv13506

Modified Files:
pcm_lib.c
Log Message:
fixed the infinite loop at capture-draining on oss-emulation.

Index: pcm_lib.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/core/pcm_lib.c,v retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21

pcm_lib.c 30 Oct 2002 18:12:46 -0000 1.21 line 2144

Quoted 8 lines
pcm_lib.c 30 Oct 2002 18:12:46 -0000 1.21 renamed from pcm_lib.c 12 Oct 2002 14:38:42 -0000 1.20 +1 -1
@@ -2138,7 +2138,7 @@
                snd_pcm_uframes_t frames, appl_ptr, appl_ofs;
                snd_pcm_uframes_t avail;
                snd_pcm_uframes_t cont;
-               if (runtime->sleep_min == 0 && runtime->status->state == SNDRV_PCM_STATE_RUNNING)
+               if (runtime->sleep_min == 0 && (runtime->status->state == SNDRV_PCM_STATE_RUNNING || runtime->status->state == SNDRV_PCM_STATE_DRAINING))
                        snd_pcm_update_hw_ptr(substream);
                avail = snd_pcm_capture_avail(runtime);
                if (runtime->status->state == SNDRV_PCM_STATE_DRAINING) {

What are you trying to do here?

What's the reason to call snd_pcm_update_hw_ptr when PCM is not running?

Signature · 12 lines
Abramo Bagnara                       mailto:[email protected]

Opera Unica                          Phone: +39.546.656023
Via Emilia Interna, 140
48014 Castel Bolognese (RA) - Italy


-------------------------------------------------------
This sf.net email is sponsored by: Influence the future 
of Java(TM) technology. Join the Java Community 
Process(SM) (JCP(SM)) program now. 
http://ads.sourceforge.net/cgi-bin/redirect.pl?sunm0004en
#2 lore raw

At Wed, 30 Oct 2002 20:45:11 +0100,

Quoted 31 lines · Abramo Bagnara
Quoted 18 lines · Takashi Iwai

Update of /cvsroot/alsa/alsa-kernel/core
In directory usw-pr-cvs1:/tmp/cvs-serv13506

Modified Files:
pcm_lib.c
Log Message:
fixed the infinite loop at capture-draining on oss-emulation.

Index: pcm_lib.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/core/pcm_lib.c,v retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21

pcm_lib.c 30 Oct 2002 18:12:46 -0000 1.21 line 2144

Quoted 8 lines
pcm_lib.c 30 Oct 2002 18:12:46 -0000 1.21 renamed from pcm_lib.c 12 Oct 2002 14:38:42 -0000 1.20 +1 -1
@@ -2138,7 +2138,7 @@
                snd_pcm_uframes_t frames, appl_ptr, appl_ofs;
                snd_pcm_uframes_t avail;
                snd_pcm_uframes_t cont;
-               if (runtime->sleep_min == 0 && runtime->status->state == SNDRV_PCM_STATE_RUNNING)
+               if (runtime->sleep_min == 0 && (runtime->status->state == SNDRV_PCM_STATE_RUNNING || runtime->status->state == SNDRV_PCM_STATE_DRAINING))
                        snd_pcm_update_hw_ptr(substream);
                avail = snd_pcm_capture_avail(runtime);
                if (runtime->status->state == SNDRV_PCM_STATE_DRAINING) {

What are you trying to do here?

Quoted 1 line

What's the reason to call snd_pcm_update_hw_ptr when PCM is not running?

sorry, my mistake.
already fixed by Jaroslav.

Takashi (..needs vacation soon)

-------------------------------------------------------
This sf.net email is sponsored by: Influence the future of Java(TM) technology. Join the Java Community Process(SM) (JCP(SM)) program now.
http://ads.sourceforge.net/cgi-bin/redirect.pl?sunm0004en