Skip to contentSkip to conversation

timers: scsi, input, networking

PATCH In review Andrew Morton 2 participants 3 messages Nov 5, 2002

Subsystems (5)
Networking SCSI IPv4/IPv6 Input drivers +1 more subsystems
lore
Share & tools
lore

Andrew Morton

author
#0 lore raw

PATCH 3/4 timers: scsi, input, networking

The patches which I needed to avoid the warnings with my build.

drivers/scsi/scsi.c renamed from drivers/scsi/scsi.c~scsi-timer-init +2 -0
@@ -603,6 +603,7 @@ inline void __scsi_release_command(Scsi_
 				 GFP_DMA : 0));
 		if(newSCpnt) {
 			memset(newSCpnt, 0, sizeof(Scsi_Cmnd));
+			init_timer(&newSCpnt->eh_timeout);
 			newSCpnt->host = SDpnt->host;
 			newSCpnt->device = SDpnt;
 			newSCpnt->target = SDpnt->id;

@@ -1551,6 +1552,7 @@ void scsi_build_commandblocks(Scsi_Devic
 	}
 
 	memset(SCpnt, 0, sizeof(Scsi_Cmnd));
+	init_timer(&SCpnt->eh_timeout);
 	SCpnt->host = SDpnt->host;
 	SCpnt->device = SDpnt;
 	SCpnt->target = SDpnt->id;

.

drivers/input/serio/i8042.c renamed from drivers/input/serio/i8042.c~i8042-timer-init +1 -0
@@ -844,6 +844,7 @@ int __init i8042_init(void)
 
 	i8042_port_register(&i8042_kbd_values, &i8042_kbd_port);
 
+	init_timer(&i8042_timer);
 	i8042_timer.function = i8042_timer_func;
 	mod_timer(&i8042_timer, jiffies + I8042_POLL_PERIOD);

.

net/ipv4/route.c renamed from net/ipv4/route.c~ip4-rt-timer-init +2 -0
@@ -2526,7 +2526,9 @@ void __init ip_rt_init(void)
 	devinet_init();
 	ip_fib_init();
 
+	init_timer(&rt_flush_timer);
 	rt_flush_timer.function = rt_run_flush;
+	init_timer(&rt_periodic_timer);
 	rt_periodic_timer.function = rt_check_expire;
 
 	/* All the timers, started at system startup tend

.

net/ipv4/inetpeer.c renamed from net/ipv4/inetpeer.c~inetpeer-timer-init +1 -1
@@ -98,7 +98,7 @@ spinlock_t inet_peer_unused_lock = SPIN_
 
 static void peer_check_expire(unsigned long dummy);
 static struct timer_list peer_periodic_timer =
-	{ .function = &peer_check_expire };
+	TIMER_INITIALIZER(peer_check_expire, 0, 0);
 
 /* Exported for sysctl_net_ipv4.  */
 int inet_peer_gc_mintime = 10 * HZ,

.

net/ipv4/tcp_minisocks.c renamed from net/ipv4/tcp_minisocks.c~tcp_minisocks-timer-init +3 -2
@@ -428,7 +428,7 @@ static void tcp_twkill(unsigned long);
 
 static struct tcp_tw_bucket *tcp_tw_death_row[TCP_TWKILL_SLOTS];
 static spinlock_t tw_death_lock = SPIN_LOCK_UNLOCKED;
-static struct timer_list tcp_tw_timer = { .function = tcp_twkill };
+static struct timer_list tcp_tw_timer = TIMER_INITIALIZER(tcp_twkill, 0, 0);
 
 static void SMP_TIMER_NAME(tcp_twkill)(unsigned long dummy)
 {

@@ -495,7 +495,8 @@ void tcp_tw_deschedule(struct tcp_tw_buc
 static int tcp_twcal_hand = -1;
 static int tcp_twcal_jiffie;
 static void tcp_twcal_tick(unsigned long);
-static struct timer_list tcp_twcal_timer = {.function = tcp_twcal_tick};
+static struct timer_list tcp_twcal_timer =
+		TIMER_INITIALIZER(tcp_twcal_tick, 0, 0);
 static struct tcp_tw_bucket *tcp_twcal_row[TCP_TW_RECYCLE_SLOTS];
 
 void tcp_tw_schedule(struct tcp_tw_bucket *tw, int timeo)

.

#1 lore raw

Hmm.. The subject says "scsi, input, networking", but there is only a scsi part to the patch. Messed up patch?

Linus

Quoted 25 lines · Andrew Morton

The patches which I needed to avoid the warnings with my build.

drivers/scsi/scsi.c renamed from drivers/scsi/scsi.c~scsi-timer-init +2 -0
@@ -603,6 +603,7 @@ inline void __scsi_release_command(Scsi_
 				 GFP_DMA : 0));
 		if(newSCpnt) {
 			memset(newSCpnt, 0, sizeof(Scsi_Cmnd));
+			init_timer(&newSCpnt->eh_timeout);
 			newSCpnt->host = SDpnt->host;
 			newSCpnt->device = SDpnt;
 			newSCpnt->target = SDpnt->id;

@@ -1551,6 +1552,7 @@ void scsi_build_commandblocks(Scsi_Devic
 	}
 
 	memset(SCpnt, 0, sizeof(Scsi_Cmnd));
+	init_timer(&SCpnt->eh_timeout);
 	SCpnt->host = SDpnt->host;
 	SCpnt->device = SDpnt;
 	SCpnt->target = SDpnt->id;
author
#2 lore raw
Quoted 4 lines · Linus Torvalds

Hmm.. The subject says "scsi, input, networking", but there is only a scsi part to the patch. Messed up patch?

I stuck five micropatches into one email. Here's a rollup of the same:

 drivers/input/serio/i8042.c |    1 +
 drivers/scsi/scsi.c         |    2 ++
 net/ipv4/inetpeer.c         |    2 +-
 net/ipv4/route.c            |    2 ++
 net/ipv4/tcp_minisocks.c    |    5 +++--
 5 files changed, 9 insertions(+), 3 deletions(-)
drivers/scsi/scsi.c renamed from drivers/scsi/scsi.c~rollup +2 -0
@@ -603,6 +603,7 @@ inline void __scsi_release_command(Scsi_
 				 GFP_DMA : 0));
 		if(newSCpnt) {
 			memset(newSCpnt, 0, sizeof(Scsi_Cmnd));
+			init_timer(&newSCpnt->eh_timeout);
 			newSCpnt->host = SDpnt->host;
 			newSCpnt->device = SDpnt;
 			newSCpnt->target = SDpnt->id;

@@ -1551,6 +1552,7 @@ void scsi_build_commandblocks(Scsi_Devic
 	}
 
 	memset(SCpnt, 0, sizeof(Scsi_Cmnd));
+	init_timer(&SCpnt->eh_timeout);
 	SCpnt->host = SDpnt->host;
 	SCpnt->device = SDpnt;
 	SCpnt->target = SDpnt->id;
drivers/input/serio/i8042.c renamed from drivers/input/serio/i8042.c~rollup +1 -0
@@ -844,6 +844,7 @@ int __init i8042_init(void)
 
 	i8042_port_register(&i8042_kbd_values, &i8042_kbd_port);
 
+	init_timer(&i8042_timer);
 	i8042_timer.function = i8042_timer_func;
 	mod_timer(&i8042_timer, jiffies + I8042_POLL_PERIOD);
net/ipv4/route.c renamed from net/ipv4/route.c~rollup +2 -0
@@ -2526,7 +2526,9 @@ void __init ip_rt_init(void)
 	devinet_init();
 	ip_fib_init();
 
+	init_timer(&rt_flush_timer);
 	rt_flush_timer.function = rt_run_flush;
+	init_timer(&rt_periodic_timer);
 	rt_periodic_timer.function = rt_check_expire;
 
 	/* All the timers, started at system startup tend
net/ipv4/inetpeer.c renamed from net/ipv4/inetpeer.c~rollup +1 -1
@@ -98,7 +98,7 @@ spinlock_t inet_peer_unused_lock = SPIN_
 
 static void peer_check_expire(unsigned long dummy);
 static struct timer_list peer_periodic_timer =
-	{ .function = &peer_check_expire };
+	TIMER_INITIALIZER(peer_check_expire, 0, 0);
 
 /* Exported for sysctl_net_ipv4.  */
 int inet_peer_gc_mintime = 10 * HZ,
net/ipv4/tcp_minisocks.c renamed from net/ipv4/tcp_minisocks.c~rollup +3 -2
@@ -428,7 +428,7 @@ static void tcp_twkill(unsigned long);
 
 static struct tcp_tw_bucket *tcp_tw_death_row[TCP_TWKILL_SLOTS];
 static spinlock_t tw_death_lock = SPIN_LOCK_UNLOCKED;
-static struct timer_list tcp_tw_timer = { .function = tcp_twkill };
+static struct timer_list tcp_tw_timer = TIMER_INITIALIZER(tcp_twkill, 0, 0);
 
 static void SMP_TIMER_NAME(tcp_twkill)(unsigned long dummy)
 {

@@ -495,7 +495,8 @@ void tcp_tw_deschedule(struct tcp_tw_buc
 static int tcp_twcal_hand = -1;
 static int tcp_twcal_jiffie;
 static void tcp_twcal_tick(unsigned long);
-static struct timer_list tcp_twcal_timer = {.function = tcp_twcal_tick};
+static struct timer_list tcp_twcal_timer =
+		TIMER_INITIALIZER(tcp_twcal_tick, 0, 0);
 static struct tcp_tw_bucket *tcp_twcal_row[TCP_TW_RECYCLE_SLOTS];
 
 void tcp_tw_schedule(struct tcp_tw_bucket *tw, int timeo)

.