Skip to contentSkip to conversation

scsi_reset_provider() in scsi_error.c lk2.5.52

PATCH New Douglas Gilbert 1 participant 1 message Dec 23, 2002 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi_reset_provider() in scsi_error.c lk2.5.52

While testing Willem's last ide-scsi "rev1" patch with sg_reset I found that scsi_reset_provider() attempts to delete a timer that has not been set.

A crude patch is attached that stops the kernel noise. Hopefully James can improve on it.

Doug Gilbert

drivers/scsi/scsi_error.c2552res renamed from drivers/scsi/scsi_error.c +4 -0
@@ -1811,6 +1811,10 @@
 	 */
 	SCpnt->pid			= 0;
 
+	/* Code expects a timer to be set, so set one for 120 seconds */
+	init_timer(&SCpnt->eh_timeout);
+	scsi_add_timer(SCpnt, 120 * HZ, scsi_eh_times_out);
+
 	rtn = scsi_new_reset(SCpnt, flag);
 
 	scsi_delete_timer(SCpnt);