spin_locks without smp.
Quoted 6 lines · Alan
Quoted 2 lines · William Lee Irwin III
Okay, what I'm getting here is that the UP case already has preempt disabled b/c the locks are taken in IRQ context?
The tx/timeout path isnt always in IRQ context.
It is.
tx and timeout are both called at BH context with the dev_xmit spinlock held. See Documentation/networking/netdevices.txt
What about
disable_irq(); spin_lock(&np->lock);
That's what 8390.c uses, no need for an #ifdef.
--
Manfred
Quoted 5 lines · Manfred Spraul
disable_irq(); spin_lock(&np->lock);That's what 8390.c uses, no need for an #ifdef.
Does someone have a card they can test that on. If so then I agree entirely it is the best way to go