Skip to contentSkip to conversation

2.5.56 sound/oss/sb_mixer.c bounds check

PATCH In review ryan 3 participants 7 messages Jan 15, 2003 Sound

lore
Share & tools
lore

ryan

author
#0 lore raw

PATCH 1/1 2.5.56 sound/oss/sb_mixer.c bounds check

sound/oss/sb_mixer.c Tue Jan 14 22:06:20 2003 renamed from sound/oss/sb_mixer.c Fri Jan 10 15:11:27 2003 +3 -0
diff -urN a/sound/oss/sb_mixer.c b/sound/oss/sb_mixer.c
@@ -333,6 +333,9 @@
                        break;
 
                default:
+                       /* bounds check */
+                       if (dev >= sizeof(smw_mix_regs))
+                               return -EINVAL;
                        reg = smw_mix_regs[dev];
                        if (reg == 0)
                                return -EINVAL;
#1 lore raw
Quoted 5 lines · ryan

diff -urN a/sound/oss/sb_mixer.c b/sound/oss/sb_mixer.c

sound/oss/sb_mixer.c Tue Jan 14 22:06:20 2003 line 341

Quoted 9 lines
sound/oss/sb_mixer.c Tue Jan 14 22:06:20 2003 renamed from sound/oss/sb_mixer.c Fri Jan 10 15:11:27 2003 +3 -0
@@ -333,6 +333,9 @@
                         break;
 
                 default:
+                       /* bounds check */
+                       if (dev >= sizeof(smw_mix_regs))
+                               return -EINVAL;
                         reg = smw_mix_regs[dev];
                         if (reg == 0)
                                 return -EINVAL;

Yup.

It would be better to do:

	if (dev < 0 || dev >= ARRAY_SIZE(smw_mix_regs))
author
#2 lore raw
Quoted 5 lines

Yup.

It would be better to do:

	if (dev < 0 || dev >= ARRAY_SIZE(smw_mix_regs))

yup, much better. i did a little housecleaning on the whole file, as well as 2 more bounds checks in appropriate places.

i'm sorry to ask, but i'm new -- i've got a ~500 line patch, and my email client is wrapping at 80 chars (unfortunately some lines run over 80 chars), is sending an attachment in ascii format ok? i've seen some patches sent as attachments, not sure.

waiting for a yes/no response, please cc me

#3 lore raw
Quoted 11 lines · ryan
Quoted 5 lines

Yup.

It would be better to do:

    if (dev < 0 || dev >= ARRAY_SIZE(smw_mix_regs))

yup, much better. i did a little housecleaning on the whole file, as well as 2 more bounds checks in appropriate places.

i'm sorry to ask, but i'm new -- i've got a ~500 line patch, and my email client is wrapping at 80 chars (unfortunately some lines run over 80 chars), is sending an attachment in ascii format ok? i've seen some patches sent as attachments, not sure.

Oh let me rant. You're using mozilla. I just raised a bug against its cute habit of mangling outgoing text. I've just spent four days trying to find a workable Linux email client (sophisticated UI, sophisticated IMAP support, sophisticated searching, doesn't mangle incoming or outgoing messages) and have failed. Netscape 4.x is still the closest.

kmail is good, but its threading view is hopeless

evolution merrily mangles stuff and is buggy as a bunch of bananas.

Mozilla likes to go for multi-minute CPU burns if you try to handle a large amount of data. And it mangles outgoing patches.

Of the text-based MUA's pine is the only one which seems to have respectable IMAP support, but the interface is klunky.

Sigh. Where were we? Oh yes. Inline text is best, attachments are fine.
text/plain if poss.

<send, mangle>

#4 lore raw

(OT) Re: [PATCH] 2.5.56 sound/oss/sb_mixer.c bounds check

Quoted 5 lines · On Tue, 14 Jan 2003 20:36:35 -0800 Andrew Morton <[email protected]> wrote:

Oh let me rant. You're using mozilla. I just raised a bug against its cute habit of mangling outgoing text. I've just spent four days trying to find a workable Linux email client (sophisticated UI, sophisticated IMAP support, sophisticated searching, doesn't mangle incoming or outgoing messages) and have failed. Netscape 4.x is still the closest.

Have you tried Sylpheed? (http://sylpheed.good-day.net/index.cgi.en)

#5 lore raw

Re: (OT) Re: [PATCH] 2.5.56 sound/oss/sb_mixer.c bounds check

Quoted 10 lines · On Wed, 15 Jan 2003 14:34:36 +0900 Bruce Harada <[email protected]> wrote:
Quoted 5 lines · On Tue, 14 Jan 2003 20:36:35 -0800 Andrew Morton <[email protected]> wrote:

Oh let me rant. You're using mozilla. I just raised a bug against its cute habit of mangling outgoing text. I've just spent four days trying to find a workable Linux email client (sophisticated UI, sophisticated IMAP support, sophisticated searching, doesn't mangle incoming or outgoing messages) and have failed. Netscape 4.x is still the closest.

Have you tried Sylpheed? (http://sylpheed.good-day.net/index.cgi.en)

Supports external editor, fast, ability to import a file into message body, decent IMAP support, patches actually still apply after a round trip.

A few glitches, but looking good, thanks!