Skip to contentSkip to conversation

access to GPLONLY symbol SNAFU?

DISCUSSION Florian Bomers 2 participants 2 messages Mar 8, 2003 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi,

just tried to ALSA 0.9.0rc8b on a stock-Redhat 8.0 with redhat kernel 2.4.18-14. I got a series of similar warnings:

...
In file included from /root/alsa-driver-0.9.0rc8b/include/sound/driver.h:43,

                 from ../../alsa-kernel/core/ioctl32/ioctl32.c:21,
                 from ioctl32.c:2:
/root/alsa-driver-0.9.0rc8b/include/adriver.h:325:1: warning: "vmalloc_to_page" redefined
In file included from /usr/src/linux-2.4.18-14/include/linux/modversions.h:1217,
                 from /root/alsa-driver-0.9.0rc8b/include/adriver.h:40,
                 from /root/alsa-driver-0.9.0rc8b/include/sound/driver.h:43,
                 from ../../alsa-kernel/core/ioctl32/ioctl32.c:21,
                 from ioctl32.c:2:

/usr/src/linux-2.4.18-14/include/linux/modules/ksyms.ver:2892:1: warning: this
...

I saw that the patch suggested by Takashi (see below) was integrated in 0.9.0rc8b - but I guess it doesn't apply to my 2.4.18 kernel, because when I changed it, compilation went through fine:

alsa-driver/include/adriver.h:322

        /* vmalloc_to_page wrapper */
-       #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 4, 19)
+       #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 4, 18)
        struct page *snd_compat_vmalloc_to_page(void *addr);
        #define vmalloc_to_page(addr) snd_compat_vmalloc_to_page(addr)
        #endif

and analogous changes in
alsa-driver/acore/memory_wrapper.c
alsa-driver/acore/memalloc.c.

Maybe you should verify in which kernel version this modification was actually made to the vmalloc thing...

Florian

Quoted 122 lines

Message: 7
Date: Tue, 04 Mar 2003 17:30:30 +0100
From: Takashi Iwai <[email protected]>
To: Paul Davis <[email protected]>
Cc: Jaroslav Kysela <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [Alsa-devel] access to GPLONLY symbol SNAFU?

At Tue, 04 Mar 2003 11:09:14 -0500,

Quoted 10 lines · Paul Davis
Quoted 7 lines
Quoted 2 lines

module-init-tools 0.9.10

^^^^^^^^^^^^^^^^^

Probably bug in this package. I don't know the exact status of modules in 2.5 (it's dramaticaly changing), but all ALSA modules are GPLed, thus this problem shouldn't occur.

good first guess, but no luck. i uninstalled it, reinstalled modutils 2.4.9, and the same problem occurs.

modutils-2.4.9 is fairly old.. isn't it 2.4.19?

Quoted 6 lines

i don't understand how this
happens: the kernel image contains only vmalloc_to_page, but /proc/ksyms has only the GPL version. i was hoping that someone with even more experience of this than i might have an idea what has gone wrong. it all works under 2.5 BTW, but i can't use 2.5 right now because the main serial driver is broken.

not the real solution but a workaround would be to change the condition in alsa-driver/include/adriver.h line 322 like below

        /* vmalloc_to_page wrapper */
==>     #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 4, 19)
        struct page *snd_compat_vmalloc_to_page(void *addr);
        #define vmalloc_to_page(addr) snd_compat_vmalloc_to_page(addr)
        #endif

and the corresponding part definition in
alsa-driver/acore/memory_wrapper.c and
EXPORT_SYMBOL() in alsa-driver/acore/sound.c.

or, try 2.4.20 or later. it's changed as without GPL suffix.

ciao,

Takashi

--__--__--

Message: 8
Date: Tue, 4 Mar 2003 17:40:59 +0100
From: Martin Langer <[email protected]>
To: Paul Davis <[email protected]>, [email protected]
Cc: [email protected]
Subject: Re: [Alsa-devel] access to GPLONLY symbol SNAFU?

Quoted 7 lines · Paul Davis
Quoted 6 lines
Quoted 1 line

module-init-tools 0.9.10

^^^^^^^^^^^^^^^^^

Probably bug in this package. I don't know the exact status of modules in 2.5 (it's dramaticaly changing), but all ALSA modules are GPLed, thus this problem shouldn't occur.

Quoted 8 lines

good first guess, but no luck. i uninstalled it, reinstalled modutils 2.4.9, and the same problem occurs. i don't understand how this
happens: the kernel image contains only vmalloc_to_page, but /proc/ksyms has only the GPL version. i was hoping that someone with even more experience of this than i might have an idea what has gone wrong. it all works under 2.5 BTW, but i can't use 2.5 right now because the main serial driver is broken.

Hmmmm don't know, but I found a small bug in hdsp.c.

martin

hdsp.c Tue Mar 4 17:34:32 2003 renamed from hdsp.c.ORIGINAL Tue Mar 4 17:33:50 2003 +1 -2
@@ -72,7 +72,7 @@
 MODULE_DESCRIPTION("RME Hammerfall DSP");
 MODULE_LICENSE("GPL");
 MODULE_CLASSES("{sound}");
-MODULE_DEVICES("{{RME,Hammerfall-DSP},");
+MODULE_DEVICES("{{RME,Hammerfall-DSP}}");
 
 typedef enum {
        Digiface,
 
--__--__--

Message: 9
To: Takashi Iwai <[email protected]>
cc: Jaroslav Kysela <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [Alsa-devel] access to GPLONLY symbol SNAFU?
Date: Tue, 04 Mar 2003 11:44:03 -0500
From: Paul Davis <[email protected]>

Quoted 4 lines
Quoted 2 lines

good first guess, but no luck. i uninstalled it, reinstalled modutils 2.4.9, and the same problem occurs.

modutils-2.4.9 is fairly old.. isn't it 2.4.19?

GACK!! this is what happens when the output of ftp's "ls" command scrolls off the screen, and you conclude that 2.4.9 is the latest.

reinstalling 2.4.19 fixes the problem. thanks takashi!

--p

--__--__--

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

End of Alsa-devel Digest

Signature · 11 lines
Florian Bomers
Java Sound
Java Software/Sun Microsystems, Inc.
http://java.sun.com/products/java-media/sound/


-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
for complex code. Debugging C/C++ programs can leave you feeling lost and 
disoriented. TotalView can help you find your way. Available on major UNIX 
and Linux platforms. Try it free. www.etnus.com
#2 lore raw
Quoted 27 lines · Florian Bomers

Hi,

just tried to ALSA 0.9.0rc8b on a stock-Redhat 8.0 with redhat kernel 2.4.18-14. I got a series of similar warnings:

...
In file included from /root/alsa-driver-0.9.0rc8b/include/sound/driver.h:43,

                 from ../../alsa-kernel/core/ioctl32/ioctl32.c:21,
                 from ioctl32.c:2:
/root/alsa-driver-0.9.0rc8b/include/adriver.h:325:1: warning: "vmalloc_to_page" redefined
In file included from /usr/src/linux-2.4.18-14/include/linux/modversions.h:1217,
                 from /root/alsa-driver-0.9.0rc8b/include/adriver.h:40,
                 from /root/alsa-driver-0.9.0rc8b/include/sound/driver.h:43,
                 from ../../alsa-kernel/core/ioctl32/ioctl32.c:21,
                 from ioctl32.c:2:

/usr/src/linux-2.4.18-14/include/linux/modules/ksyms.ver:2892:1: warning: this
...

I saw that the patch suggested by Takashi (see below) was integrated in 0.9.0rc8b - but I guess it doesn't apply to my 2.4.18 kernel, because when I changed it, compilation went through fine:

alsa-driver/include/adriver.h:322

        /* vmalloc_to_page wrapper */

Review

Quoted 5 lines
(quoted diff) +1 -1
-       #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 4, 19)
+       #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 4, 18)
        struct page *snd_compat_vmalloc_to_page(void *addr);
        #define vmalloc_to_page(addr) snd_compat_vmalloc_to_page(addr)
        #endif

This problem will be fixed in the 0.9.0rc8d driver.

Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project, SuSE Labs

-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger for complex code. Debugging C/C++ programs can leave you feeling lost and disoriented. TotalView can help you find your way. Available on major UNIX and Linux platforms. Try it free. www.etnus.com