Skip to contentSkip to conversation

: Fix oops with pending/23_REJECT-headroom-tcprst.patch

PATCH In review Patrick McHardy 2 participants 2 messages Mar 11, 2003 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : Fix oops with pending/23_REJECT-headroom-tcprst.patch

Hi Harald,
this patch fixes an oops with 23-REJECT-headroom-tcprst.patch (nskb is used before copy).

Regards,
Patrick

? conntrack-fragments
? linux-2.4.20-clean
? linux-2.4.20-nf
? linux-2.4.20.tar.bz2
? netfilter-nobssinit.diff
Index: patch-o-matic/pending/23_REJECT-headroom-tcprst.patch
===================================================================
RCS file: /cvspublic/netfilter/patch-o-matic/pending/23_REJECT-headroom-tcprst.patch,v retrieving revision 1.2

pending/23_REJECT-headroom-tcprst.patch +3 -3
diff -u -r1.2 23_REJECT-headroom-tcprst.patch
@@ -14,9 +14,9 @@
  		return;
  
 +	/* Routing: if not headed for us, route won't like source */
-+	if (ip_route_output(&rt, nskb->nh.iph->daddr,
-+			    local ? nskb->nh.iph->saddr : 0,
-+			    RT_TOS(nskb->nh.iph->tos) | RTO_CONN,
++	if (ip_route_output(&rt, oldskb->nh.iph->daddr,
++			    local ? oldskb->nh.iph->saddr : 0,
++			    RT_TOS(oldskb->nh.iph->tos) | RTO_CONN,
 +			    0) != 0)
 +		return;
 +
#1 lore raw
Quoted 3 lines · Patrick McHardy

Hi Harald,
this patch fixes an oops with 23-REJECT-headroom-tcprst.patch (nskb is used before copy).

thanks, stupid mistake while porting the fix from 2.5.x -> 2.4.x

applied (and bug 22 updated)

Quoted 2 lines

Regards,
Patrick

Signature · 5 lines
- Harald Welte <[email protected]>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie