Skip to contentSkip to conversation

Condition match - error while parsing parameters

PATCH In review Stephane Ouellette 2 participants 2 messages Mar 15, 2003 – Mar 26, 2003 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Condition match - error while parsing parameters

Folks,

here are two small patches that fix a parsing error. The error made
the condition match module think that multiple conditions were specified on the iptables command line.

Stephane Ouellette.

userspace/extensions/libip6t_condition.c +4 -4
@@ -41,11 +41,11 @@
 
 	check_inverse(optarg, &invert, &optind, 0);
 
-	if (*flags)
-		exit_error(PARAMETER_PROBLEM,
-			   "Can't specify multiple conditions");
-
 	if (c == 'X') {
+		if (*flags)
+			exit_error(PARAMETER_PROBLEM,
+				   "Can't specify multiple conditions");
+
 		if (strlen(argv[optind - 1]) < CONDITION6_NAME_LEN)
 			strcpy(info->name, argv[optind - 1]);
 		else
userspace/extensions/libipt_condition.c +4 -4
@@ -41,11 +41,11 @@
 
 	check_inverse(optarg, &invert, &optind, 0);
 
-	if (*flags)
-		exit_error(PARAMETER_PROBLEM,
-			   "Can't specify multiple conditions");
-
 	if (c == 'X') {
+		if (*flags)
+			exit_error(PARAMETER_PROBLEM,
+				   "Can't specify multiple conditions");
+
 		if (strlen(argv[optind - 1]) < CONDITION_NAME_LEN)
 			strcpy(info->name, argv[optind - 1]);
 		else
#1 lore raw
Quoted 5 lines · Stephane Ouellette

Folks,

here are two small patches that fix a parsing error. The error made
the condition match module think that multiple conditions were specified on the iptables command line.

Thanks for the fix, applied.

Quoted 3 lines

Stephane Ouellette.

Signature · 5 lines
- Harald Welte <[email protected]>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie