Skip to contentSkip to conversation

dead code elimination in ip6_queue.c

PATCH In review Stephane Ouellette 3 participants 4 messages Mar 15, 2003 – Mar 26, 2003

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dead code elimination in ip6_queue.c

Folks,

the following patch removes dead code in ip6_queue.c

Stephane Ouellette.

net/ipv6/netfilter/ip6_queue.c +0 -3
@@ -265,8 +265,6 @@
 	return skb;
 
 nlmsg_failure:
-	if (skb)
-		kfree_skb(skb);
 	*errp = -EINVAL;
 	printk(KERN_ERR "ip6_queue: error creating packet message\n");
 	return NULL;
@@ -730,7 +728,6 @@
 
 static int __init init(void)
 {
-	
 	return init_or_cleanup(1);
 }
 
#1 lore raw
Quoted 4 lines · Stephane Ouellette

Folks,

the following patch removes dead code in ip6_queue.c

Incorrect, see NLMSG_PUT().

- James

Signature · 2 lines
James Morris
<[email protected]>
#2 lore raw
Quoted 11 lines · James Morris
Quoted 6 lines · Stephane Ouellette

Folks,

the following patch removes dead code in ip6_queue.c

Quoted 6 lines

Incorrect, see NLMSG_PUT().

- James

James,

I'm sorry. I didn't check the macros...

Thank you for pointing my mistake.

Stephane

#3 lore raw
In reply to Stephane Ouellette
Quoted 3 lines · Stephane Ouellette

Folks,

the following patch removes dead code in ip6_queue.c

the same code is in ip_queue.c. I've created a new patch for the 'pending' repository fixing both cases.

Quoted 1 line

Stephane Ouellette.

Signature · 5 lines
- Harald Welte <[email protected]>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie