Skip to contentSkip to conversation

scsi_ioctl.c for SEND_DIAGNOSTIC

PATCH New Douglas Gilbert 1 participant 1 message Mar 26, 2003 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi_ioctl.c for SEND_DIAGNOSTIC

While doing foreground extended self tests with smartmontools I found that the timeout was much to short for SCSI_IOCTL_SEND_COMMAND. On my 18 GB disk that test takes about 12 minutes.

Attachment extends timeout to the same as FORMAT (i.e. 2 hours). The patch is against lk 2.5.66 .

BTW Foreground extended self tests (and FORMATs :-)) should not be done on disks with mounted partitions.

Doug Gilbert

drivers/scsi/scsi_ioctl.c2566dpg renamed from drivers/scsi/scsi_ioctl.c +1 -0
@@ -298,6 +298,7 @@
 		goto error;
 
 	switch (opcode) {
+	case SEND_DIAGNOSTIC:
 	case FORMAT_UNIT:
 		timeout = FORMAT_UNIT_TIMEOUT;
 		retries = 1;