remove unnecessary initialization to 0
Subsystems (2)
PATCH 1/1 remove unnecessary initialization to 0
This patch removes a couple of unnecessary memset()s for data which is located in the bss segment.
Regards,
Patrick
net/ipv4/netfilter/ip_conntrack_ftp.c +0 -1
@@ -405,7 +405,6 @@ ports[0 ] =FTP_PORT ;for (i =0 ; (i <MAX_PORTS ) && ports[i]; i++) { -memset (&ftp[i],0 ,sizeof (struct ip_conntrack_helper )); ftp[i].tuple.src.u.tcp.port =htons (ports[i]); ftp[i].tuple.dst.protonum =IPPROTO_TCP ; ftp[i].mask.src.u.tcp.port =0xFFFF ;
net/ipv4/netfilter/ip_conntrack_irc.c +0 -2
@@ -259,8 +259,6 @@for (i =0 ; (i <MAX_PORTS ) && ports[i]; i++) { hlpr = &irc_helpers[i]; -memset (hlpr,0 , -sizeof (struct ip_conntrack_helper )); hlpr->tuple.src.u.tcp.port =htons (ports[i]); hlpr->tuple.dst.protonum =IPPROTO_TCP ; hlpr->mask.src.u.tcp.port =0xFFFF ;
net/ipv4/netfilter/ip_nat_ftp.c +0 -3
@@ -306,9 +306,6 @@ ports[0 ] =FTP_PORT ;for (i =0 ; (i <MAX_PORTS ) && ports[i]; i++) { - -memset (&ftp[i],0 ,sizeof (struct ip_nat_helper )); - ftp[i].tuple.dst.protonum =IPPROTO_TCP ; ftp[i].tuple.src.u.tcp.port =htons (ports[i]); ftp[i].mask.dst.protonum =0xFFFF ;
net/ipv4/netfilter/ip_nat_irc.c +0 -3
@@ -243,9 +243,6 @@for (i =0 ; (i <MAX_PORTS ) && ports[i] !=0 ; i++) { hlpr = &ip_nat_irc_helpers[i]; -memset (hlpr,0 , -sizeof (struct ip_nat_helper )); - hlpr->tuple.dst.protonum =IPPROTO_TCP ; hlpr->tuple.src.u.tcp.port =htons (ports[i]); hlpr->mask.src.u.tcp.port =0xFFFF ;
net/ipv4/netfilter/ipt_ULOG.c +0 -1
@@ -320,7 +320,6 @@/* initialize ulog_buffers */ for (i =0 ; i <ULOG_MAXNLGROUPS ; i++) { -memset (&ulog_buffers[i],0 ,sizeof (ulog_buff_t));init_timer (&ulog_buffers[i].timer); ulog_buffers[i].timer.function = ulog_timer; ulog_buffers[i].timer.data = i;