Skip to contentSkip to conversation

dead code elimination in libipt_ecn.c

PATCH In review Stephane Ouellette 2 participants 2 messages Apr 4, 2003 – Apr 11, 2003 netfilter

lore
Share & tools
lore

Stephane Ouellette

author
#0 lore raw

PATCH 1/1 dead code elimination in libipt_ecn.c

Folks,

the following patch removes print_dscp() which is not used. It also
converts all structures to C99.

Regards,

Stephane Ouellette

userspace/extensions/libipt_ecn.c +15 -25
@@ -32,10 +32,10 @@
 }
 
 static struct option opts[] = {
-	{ "ecn-tcp-cwr", 0, 0, 'F' },
-	{ "ecn-tcp-ece", 0, 0, 'G' },
-	{ "ecn-ip-ect", 1, 0, 'H' },
-	{ 0 }
+	{ .name = "ecn-tcp-cwr", .has_arg = 0, .flag = 0, .val = 'F' },
+	{ .name = "ecn-tcp-ece", .has_arg = 0, .flag = 0, .val = 'G' },
+	{ .name = "ecn-ip-ect",  .has_arg = 1, .flag = 0, .val = 'H' },
+	{ .name = 0 }
 };
 
 static int

@@ -100,15 +100,6 @@
 		           "ECN match: some option required");
 }
 
-static void
-print_dscp(u_int8_t dscp, int invert, int numeric)
-{
-	if (invert)
-		fputc('!', stdout);
-
- 	printf("0x%02x ", dscp);
-}
-
 /* Prints out the matchinfo. */
 static void
 print(const struct ipt_ip *ip,

@@ -167,18 +158,17 @@
 
 static
 struct iptables_match ecn
-= { NULL,
-    "ecn",
-    IPTABLES_VERSION,
-    IPT_ALIGN(sizeof(struct ipt_ecn_info)),
-    IPT_ALIGN(sizeof(struct ipt_ecn_info)),
-    &help,
-    &init,
-    &parse,
-    &final_check,
-    &print,
-    &save,
-    opts
+= { .name          = "ecn",
+    .version       = IPTABLES_VERSION,
+    .size          = IPT_ALIGN(sizeof(struct ipt_ecn_info)),
+    .userspacesize = IPT_ALIGN(sizeof(struct ipt_ecn_info)),
+    .help          = &help,
+    .init          = &init,
+    .parse         = &parse,
+    .final_check   = &final_check,
+    .print         = &print,
+    .save          = &save,
+    .extra_opts    = opts
 };
 
 void _init(void)