Skip to contentSkip to conversation

2.5.67: ppa driver & preempt == oops

PATCH walt 2 participants 3 messages Apr 15, 2003 – Apr 16, 2003 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

walt

author
#2 lore raw
Quoted 19 lines · Patrick Mansfield

On Sun, Apr 13, 2003 at 07:44:04PM +0200, Gert Vervoort wrote:

Here is a patch against 2.5.67, can you try it out?

I did not compile let alone run with this patch.

We never hold the host_lock while calling the detect function (unlike the io_request_lock, see the bizzare 2.4 code), so acquiring it inside ppa_detect is very wrong. I don't know why your scsi scan did not hang.

drivers/scsi/ppa.c renamed from drivers/scsi/ppa.c-orig +0 -1
@@ -219,15 +219,12 @@
 	    printk("  supported by the imm (ZIP Plus) driver. If the\n");
 	    printk("  cable is marked with \"AutoDetect\", this is what has\n");
 	    printk("  happened.\n");
-	    spin_lock_irq(hreg->host_lock);
 	    return 0;
 	}

drivers/scsi/ppa.c line 230

Quoted 10 lines
drivers/scsi/ppa.c renamed from drivers/scsi/ppa.c-orig +1 -3
 	try_again = 1;
 	goto retry_entry;
-    } else {
-	spin_lock_irq(hreg->host_lock);
+    } else
 	return 1;		/* return number of hosts detected */
-    }
 }
 
 /* This is to give the ppa driver a way to modify the timings (and other

Yes! Thank you. This patch fixes the segfault of modprobe that I've been seeing for ages.

Note that the problems I have been seeing are completely different from Geert's problems. I have had no problems mounting a FAT-16 fs with the 2.5.x kernels but modprobe has been segfaulting all along, even though the ppa module works fine for me once it has been loaded.

When I compile ppa into the kernel I see a kernel panic during bootup. I will also try compiling your patch into the kernel and see if it prevents the panic.

The parallel Zip drive is the only scsi device I have, so I can't comment on the more general situation. This is the scsi section of my kernel config:

# SCSI device support
#
CONFIG_SCSI=y

#
# SCSI support type (disk, tape, CD-ROM)
#
CONFIG_BLK_DEV_SD=y
# CONFIG_CHR_DEV_ST is not set
# CONFIG_CHR_DEV_OSST is not set
# CONFIG_BLK_DEV_SR is not set
# CONFIG_CHR_DEV_SG is not set

#
# Some SCSI devices (e.g. CD jukebox) support multiple LUNs #
# CONFIG_SCSI_MULTI_LUN is not set
# CONFIG_SCSI_REPORT_LUNS is not set
# CONFIG_SCSI_CONSTANTS is not set
# CONFIG_SCSI_LOGGING is not set

#
# SCSI low-level drivers
#
# CONFIG_BLK_DEV_3W_XXXX_RAID is not set
# CONFIG_SCSI_ACARD is not set
# CONFIG_SCSI_AACRAID is not set
# CONFIG_SCSI_AIC7XXX is not set
# CONFIG_SCSI_AIC7XXX_OLD is not set
# CONFIG_SCSI_AIC79XX is not set
# CONFIG_SCSI_DPT_I2O is not set
# CONFIG_SCSI_ADVANSYS is not set
# CONFIG_SCSI_IN2000 is not set
# CONFIG_SCSI_AM53C974 is not set# CONFIG_SCSI_MEGARAID is not set # CONFIG_SCSI_BUSLOGIC is not set
# CONFIG_SCSI_CPQFCTS is not set
# CONFIG_SCSI_DMX3191D is not set
# CONFIG_SCSI_EATA is not set
# CONFIG_SCSI_EATA_PIO is not set
# CONFIG_SCSI_FUTURE_DOMAIN is not set
# CONFIG_SCSI_GDTH is not set
# CONFIG_SCSI_GENERIC_NCR5380 is not set
# CONFIG_SCSI_GENERIC_NCR5380_MMIO is not set
# CONFIG_SCSI_IPS is not set
# CONFIG_SCSI_INITIO is not set
# CONFIG_SCSI_INIA100 is not set
CONFIG_SCSI_PPA=m
CONFIG_SCSI_IMM=m
# CONFIG_SCSI_IZIP_EPP16 is not set
# CONFIG_SCSI_IZIP_SLOW_CTR is not set
# CONFIG_SCSI_NCR53C7xx is not set
# CONFIG_SCSI_SYM53C8XX_2 is not set
# CONFIG_SCSI_NCR53C8XX is not set
# CONFIG_SCSI_SYM53C8XX is not set
# CONFIG_SCSI_PCI2000 is not set
# CONFIG_SCSI_PCI2220I is not set
# CONFIG_SCSI_QLOGIC_ISP is not set
# CONFIG_SCSI_QLOGIC_FC is not set
# CONFIG_SCSI_QLOGIC_1280 is not set
# CONFIG_SCSI_U14_34F is not set
# CONFIG_SCSI_NSP32 is not set
# CONFIG_SCSI_DEBUG is not set
# CONFIG_SCSI_DC390T is not set

#3 lore raw
Quoted 7 lines · walt

Yes! Thank you. This patch fixes the segfault of modprobe that I've been seeing for ages.

Note that the problems I have been seeing are completely different from Geert's problems. I have had no problems mounting a FAT-16 fs with the 2.5.x kernels but modprobe has been segfaulting all along, even though the ppa module works fine for me once it has been loaded.

The other problem seems to be for removable media. Is your parallel zip have removable media and does the boot/dmesg output from sd attach show it as such? I haven't used a zip drive, I thought they had to be marked removable.

-- Patrick Mansfield

author
#4 lore raw
Quoted 5 lines · Patrick Mansfield
Quoted 2 lines · walt

Yes! Thank you. This patch fixes the segfault of modprobe that I've been seeing for ages.

Quoted 7 lines
Quoted 1 line

Note that the problems I have been seeing are completely different from Geert's problems. I have had no problems mounting a FAT-16 fs with the 2.5.x kernels but modprobe has been segfaulting all along, even though the ppa module works fine for me once it has been loaded.

The other problem seems to be for removable media. Is your parallel zip have removable media and does the boot/dmesg output from sd attach show it as such? I haven't used a zip drive, I thought they had to be marked removable.

Seems to be:

ppa: Version 2.07 (for Linux 2.4.x)
ppa: Found device at ID 6, Attempting to use EPP 32 bit
ppa: Found device at ID 6, Attempting to use SPP
ppa: Communication established with ID 6 using SPP scsi0 : Iomega VPI0 (ppa) interface
Vendor: IOMEGA Model: ZIP 100 Rev: C.18
Type: Direct-Access ANSI SCSI revision: 02
SCSI device sda: 196608 512-byte hdwr sectors (101 MB)
sda: Write Protect is off
sda: Mode Sense: 25 00 00 08
sda: cache data unavailable
sda: assuming drive cache: write through
/dev/scsi/host0/bus0/target6/lun0: p4
Attached scsi removable disk sda at scsi0, channel 0, id 6, lun 0

              ^^^^^^^^^