ip_conntrack_irc, allowance for quoted filenames

Resend, this time _with_ patch ...

[ please keep me in CC, not subscribed ]

When the irssi (www.irssi.org) IRC client is asked to DCC SEND a file with a filename containing spaces, it does so by leaving the spaces intact and quoting the filename (""). ip_conntrack_irc.c:parse_dcc() however can't handle the embedded spaces.

I haven't checked other clients but I assume they might do the same. Is the attached hack (against 2.4.20) acceptable? Should this be solved differently and/or elsewhere?

Rene.

@@ -82,6 +82,12 @@
 	ad_beg_p	returns pointer to first byte of addr data
 	ad_end_p	returns pointer to last byte of addr data */
 {
+	/* handle quoted arguments containing spaces */
+	if (*data == '"')
+		/* at least 14: "\" AAAAAAAA P\1\n" */
+		while (*++data != '"')
+			if (data > data_end - 14)
+				return -1;
 
 	/* at least 12: "AAAAAAAA P\1\n" */
 	while (*data++ != ' ')

Thanks a lot, I will include your patch.

This is, however, an irssi extension. the DCC specification does not include support for spaces in filenames, neither does the ircII implementation.

no, it's perfectly fine.

- Harald Welte <[email protected]>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie