Skip to contentSkip to conversation

Restore values of /vm/uuid/xend/* to recreated domains

PATCH New Masaki Kanno 1 participant 1 message Feb 4, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Restore values of /vm/uuid/xend/* to recreated domains

Hi,

When guest domains are restarted, previous values of /vm/uuid/xend/* in xenstore are lost. (e.g. previous_restart_time, last_shutdown_reason) This patch restores them to restarting domains. And we should update /vm/uuid/xend/restart_count of restarting domains, not previous domains.

Best regards,
Kan

tools/python/xen/xend/XendDomainInfo.py +9 -3
diff -r e4edc310e949 tools/python/xen/xend/XendDomainInfo.py
@@ -879,6 +879,9 @@ class XendDomainInfo:
     def _gatherVm(self, *args):
         return xstransact.Gather(self.vmpath, *args)
 
+    def _listRecursiveVm(self, *args):
+        return xstransact.ListRecursive(self.vmpath, *args)
+
     def storeVm(self, *args):
         return xstransact.Store(self.vmpath, *args)
 
@@ -1393,6 +1396,7 @@ class XendDomainInfo:
 
         self._writeVm('xend/previous_restart_time', str(now))
 
+        prev_vm_xend = self._listRecursiveVm('xend')
         new_dom_info = self.info
         try:
             if rename:
@@ -1411,8 +1415,13 @@ class XendDomainInfo:
             try:
                 new_dom = XendDomain.instance().domain_create_from_dict(
                     new_dom_info)
+                for x in prev_vm_xend[0][1]:
+                    new_dom._writeVm('xend/%s' % x[0], x[1])
                 new_dom.waitForDevices()
                 new_dom.unpause()
+                rst_cnt = new_dom._readVm('xend/restart_count')
+                rst_cnt = int(rst_cnt) + 1
+                new_dom._writeVm('xend/restart_count', str(rst_cnt))
                 new_dom._removeVm(RESTART_IN_PROGRESS)
             except:
                 if new_dom:
@@ -1448,9 +1457,6 @@ class XendDomainInfo:
         self.vmpath = XS_VMROOT + new_uuid
         # Write out new vm node to xenstore
         self._storeVmDetails()
-        rst_cnt = self._readVm('xend/restart_count')
-        rst_cnt = int(rst_cnt) + 1
-        self._writeVm('xend/restart_count', str(rst_cnt))
         self._preserve()
         return new_dom_info
 

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel